Open
Conversation
- Add authenticate_user method for user authentication flow - Fix authentication_string validation in channel to correctly check custom_string argument type
aonemd
reviewed
Mar 18, 2026
Member
aonemd
left a comment
aonemd
left a comment
There was a problem hiding this comment.
Tests are not running. Could you update the GH workflows
ubuntu-20.04 runners were retired from GitHub Actions, causing jobs to be permanently stuck in queued state. Ruby 2.6, 2.7, and 3.0 are also EOL. Update to ubuntu-latest and currently supported Ruby versions.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Supersedes #191. Adds the
authenticate_usermethod for the user authentication flow, which was missing from the Ruby SDK while already present in the Node and PHP SDKs.Changes
authenticate_user(socket_id, user_data)toPusher::ClientPusher::Utilsmoduleauthentication_stringinPusher::Channelto correctly validate thecustom_stringargument typeauthenticatemethodauthenticate_userSupersedes
#191