Skip to content

refactor(ci): add shared ci success#124

Merged
jbeckwith-oai merged 2 commits intomainfrom
codex/add-ci-success
Mar 23, 2026
Merged

refactor(ci): add shared ci success#124
jbeckwith-oai merged 2 commits intomainfrom
codex/add-ci-success

Conversation

@jbeckwith-oai
Copy link
Contributor

Add a CI Success job to the existing CI workflow, use the shared first-party action from promptfoo/.github, and keep the current PR Title Check workflow intact. Test plan: verify the workflow parses and CI Success waits for the existing PR checks.

Co-authored-by: Codex <noreply@openai.com>
Copy link

@chatgpt-codex-connector chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 7496f39582

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".


steps:
- name: Wait for all PR checks to succeed
uses: promptfoo/.github/.github/actions/ci-success@main

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Badge Pin shared action to immutable commit SHA

Replace @main with a pinned commit SHA. Referencing a moving branch allows unreviewed upstream changes to execute in this repo’s CI with GITHUB_TOKEN, which can bypass expected review and make checks non-deterministic. This is a supply-chain integrity risk for the merge gate.

Useful? React with 👍 / 👎.

Co-authored-by: Codex <noreply@openai.com>
@jbeckwith-oai jbeckwith-oai merged commit 4c258a3 into main Mar 23, 2026
7 checks passed
@jbeckwith-oai jbeckwith-oai deleted the codex/add-ci-success branch March 23, 2026 20:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant