Skip to content

Run tests against Ruby 4.0 and JRuby 10.0#327

Merged
Sinjo merged 2 commits intomainfrom
sinjo-new-rubies
Feb 5, 2026
Merged

Run tests against Ruby 4.0 and JRuby 10.0#327
Sinjo merged 2 commits intomainfrom
sinjo-new-rubies

Conversation

@Sinjo
Copy link
Member

@Sinjo Sinjo commented Feb 1, 2026

These have been released since I last did any work on this repo. Let's get our tests running on them!

@Sinjo Sinjo requested a review from dmagliola February 1, 2026 13:57
@Sinjo Sinjo force-pushed the sinjo-new-rubies branch 2 times, most recently from a37a93f to 006e0a2 Compare February 1, 2026 14:04
@Sinjo
Copy link
Member Author

Sinjo commented Feb 1, 2026

Ooh, breaking changes in 4.0! I'll get those fixed up.

@Sinjo Sinjo changed the title Run tests against Ruby 3.5 and JRuby 10.0 Run tests against Ruby 4.0 and JRuby 10.0 Feb 1, 2026
@Sinjo
Copy link
Member Author

Sinjo commented Feb 1, 2026

Let's get #328 in and rebase on top of it to fix this.

Sinjo added 2 commits February 5, 2026 16:16
These have been released since I last did any work on this repo. Let's
get our tests running on them!

Signed-off-by: Chris Sinjakli <chris@sinjakli.co.uk>
It's no longer a default gem in 4.0, so we need to add it explicitly.

Signed-off-by: Chris Sinjakli <chris@sinjakli.co.uk>
@Sinjo Sinjo merged commit 520d55e into main Feb 5, 2026
7 checks passed
@siebertm
Copy link

@Sinjo would it be possible to cut a release? We're upgrading to ruby 4.0 and this breaks our neck a bit...

@Sinjo
Copy link
Member Author

Sinjo commented Mar 10, 2026

@siebertm Hey, sorry. I was planning to do that and then #330 came in.

I've been meaning to set aside some time to dig into it, because I have a vague background memory that @dmagliola and I didn't use the URI methods for a specific reason many years ago, but I can't remember that reason.

Life has been busy for me over the last month, so I haven't had free time to sit down and do that thinking. I'll try and find some time this month.

@siebertm
Copy link

All fine! If it's not "easy" to do for you right away, I'll just add it to my own Gemfile as a workaround (thanks claude!)

# Gemfile
gem 'cgi'

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants