fix: use @chainable per-overload#8504
Open
LuLaValva wants to merge 1 commit intoprocessing:dev-2.0from
Open
Conversation
17 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@chainablemethods can't have overrides with different return types #8356Changes:
@chainablein JSDoc applies to one overload and not the whole functionp5.d.tsafternpm run generate-typesUpdated methods:
volume,speed,position,size,style,attribute,valuePR Checklist
I don't think any of these apply 😅...
linthas a bunch of warnings but none related to my code, and I don't see unit/snapshot tests for thep5.d.tsfile.npm run lintpasses