Conversation
|
niceee @yugalkaushik ! |
|
Hi @clairep94, although I think everything is working as I expected but I haven't tested it for sign in using google/github. Is there a way you know I can test it? |
Not sure the best way to test the google/github account association locally but great that you thought of that! Potentially you would look at the methods for deleting GitHub and Google and either call those routes first or fork the inner code to after where you delete the users projects |
I implemented your suggestion but testing these approach is the issue. Maybe creating some tests to check it out is the only solution. |
|
I have tested your code but it seems that the assets still remain the same. The account is getting deleted from the mongodb |
|
@Iron-56 Thank you for pointing that out. I’m actually still working on it and the PR isn’t ready yet. There are several tests that still need to be completed and I’m gradually progressing through them. I’ll write in comments once everything is properly tested and ready for review. |
Closes #1840
What's changed
Users can now permanently delete their account from the Account Settings page.
Changes
Server
DELETE /accountroute using theisAuthenticatedmiddleware.deleteAccountcontroller inauthManagement.ts.DeleteAccountRequestBodytype inserver/types/user.tsand re-exported it throughcommon/types.Client
DangerZonecomponent underclient/modules/User/components/.deleteAccountthunk inUser/actions.ts:DELETE /accountUNAUTH_USERandRESET_PROJECTon success/Translations
DangerZonenamespace toen-US/translations.jsonfor labels, buttons, and error messages.How to test
/signup./accountand scroll to Danger Zone./.I have verified that this pull request:
npm run lint)npm run test)npm run typecheck)developbranch.Fixes #123