feat: merge my pg_interval_2 fork into mainline#78
feat: merge my pg_interval_2 fork into mainline#78sunng87 wants to merge 31 commits intopiperRyan:masterfrom
Conversation
feat: add parse_sql for interval
feat: implement postgres_verbose
feat: implement Error for ParseError
feat: resolve several postgres style roundtrip issues
feat: from_postgres_verbose
fix: iso format
fix: correct to_sql format
| - name: Publish to Crates.io | ||
| env: | ||
| CARGO_REGISTRY_TOKEN: ${{ secrets.CARGO_REGISTRY_TOKEN }} | ||
| run: cargo publish --token $CARGO_REGISTRY_TOKEN |
There was a problem hiding this comment.
Is this action to publish every commit from master branch?
There was a problem hiding this comment.
Hey @sunng87 yes it was/is. On a side note I do have a local branch that I was planing to get merged in to switch it to manual approval + cargo smart release if you want that, but how do you want to CD part to work? I can help get that part done.
There was a problem hiding this comment.
It would be nice if we trigger the cargo publish when a tag is pushed.
see this for example: https://github.com/GreptimeTeam/promql-parser/blob/main/.github/workflows/release.yml
| false, | ||
| ); | ||
| format!("{} {:+} {}", year_month, self.days, time_interval) | ||
| let has_negative = self.years < 0 |
There was a problem hiding this comment.
suggestion: let's introduce a helper function like is_zeroed to make this a bit and other sections a bit more readable.
2 participants
This fork includes features: