Skip to content

gen_stub: Fix generation for @generate-legacy-arginfo 70000 #21554

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
TimWolla merged 1 commit into from
Mar 27, 2026
+1,102 −10
Merged

gen_stub: Fix generation for @generate-legacy-arginfo 70000 #21554

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions build/gen_stub.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1280,8 +1280,8 @@ class FuncInfo {
private bool $supportsCompileTimeEval;
public readonly bool $verify;
/** @var ArgInfo[] */
public readonly array $args;
public readonly ReturnInfo $return;
public /* readonly */ array $args;
public /* readonly */ ReturnInfo $return;
private readonly int $numRequiredArgs;
public readonly ?string $cond;
public bool $isUndocumentable;
Expand Down Expand Up @@ -3371,9 +3371,9 @@ class ClassInfo {
/** @var Name[] */
private readonly array $implements;
/** @var ConstInfo[] */
public readonly array $constInfos;
public /* readonly */ array $constInfos;
/** @var PropertyInfo[] */
private readonly array $propertyInfos;
private /* readonly */ array $propertyInfos;
/** @var FuncInfo[] */
public array $funcInfos;
/** @var EnumCaseInfo[] */
Expand Down
2 changes: 1 addition & 1 deletion ext/zend_test/test.stub.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
/**
* @generate-class-entries static
* @generate-c-enums
* @generate-legacy-arginfo 80000
* @generate-legacy-arginfo 70000
* @undocumentable
*/
namespace {
Expand Down
2 changes: 1 addition & 1 deletion ext/zend_test/test_arginfo.h
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

8 changes: 4 additions & 4 deletions ext/zend_test/test_decl.h
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Loading
Loading