Skip to content

Remove ifdef guards for ZIP_RDONLY #21195

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
tstarling wants to merge 2 commits into
base: master
Choose a base branch
from
+1 −9
Open

Remove ifdef guards for ZIP_RDONLY #21195

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
32c4aed
Remove ifdef guards for ZIP_RDONLY
tstarling Feb 11, 2026
72e05b1
Regenerate arginfo
tstarling Feb 11, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 0 additions & 4 deletions ext/zip/php_zip.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1463,11 +1463,7 @@ PHP_METHOD(ZipArchive, open)
}

/* open for write without option to empty the archive */
#ifdef ZIP_RDONLY
if ((flags & (ZIP_TRUNCATE | ZIP_RDONLY)) == 0) {
#else
if ((flags & ZIP_TRUNCATE) == 0) {
#endif
zend_stat_t st = {0};

/* exists and is empty */
Expand Down
2 changes: 0 additions & 2 deletions ext/zip/php_zip.stub.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -82,12 +82,10 @@ class ZipArchive implements Countable
* @cvalue ZIP_OVERWRITE
*/
public const int OVERWRITE = UNKNOWN;
#ifdef ZIP_RDONLY
/**
* @cvalue ZIP_RDONLY
*/
public const int RDONLY = UNKNOWN;
#endif

/**
* @cvalue ZIP_FL_NOCASE
Expand Down
4 changes: 1 addition & 3 deletions ext/zip/php_zip_arginfo.h
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Loading