Skip to content

fix(Menu): adjust initially drilled-in root menu height#12294

Open
tarunvashishth wants to merge 1 commit intopatternfly:mainfrom
tarunvashishth:fix/menu-drilldown-initial-state-height
Open

fix(Menu): adjust initially drilled-in root menu height#12294
tarunvashishth wants to merge 1 commit intopatternfly:mainfrom
tarunvashishth:fix/menu-drilldown-initial-state-height

Conversation

@tarunvashishth
Copy link
Copy Markdown

@tarunvashishth tarunvashishth commented Mar 26, 2026

Closes #11967

Summary by CodeRabbit

  • Bug Fixes
    • Corrected menu height calculation in the drilldown menu component example for accurate initial state rendering.

@coderabbitai
Copy link
Copy Markdown

coderabbitai bot commented Mar 26, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: b965fd66-349e-4993-9f72-705e40fa4142

📥 Commits

Reviewing files that changed from the base of the PR and between 4e03cd7 and 88c8b4d.

📒 Files selected for processing (1)
  • packages/react-core/src/components/Menu/examples/MenuWithDrilldownInitialState.tsx

Walkthrough

Updated the initial height value for a drilled-in menu example from 216 to 186 pixels, correcting the MenuContent height calculation when the component initializes in a drilled-in state.

Changes

Cohort / File(s) Summary
Menu Example Height Adjustment
packages/react-core/src/components/Menu/examples/MenuWithDrilldownInitialState.tsx
Updated menuHeights['initial-state-rootMenu'] state value from 216 to 186 to fix incorrect initial menu height rendering.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly and specifically describes the main change: adjusting the root menu height for an initially drilled-in state, which directly addresses the issue being fixed.
Linked Issues check ✅ Passed The code change adjusts the menuHeights value for 'initial-state-rootMenu' from 216 to 186px, directly addressing issue #11967's requirement to fix the root menu height when initially drilled in.
Out of Scope Changes check ✅ Passed The change is narrowly scoped to only the menuHeights value adjustment in the MenuWithDrilldownInitialState example, with no unrelated modifications to other components or functionality.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@patternfly-build
Copy link
Copy Markdown
Collaborator

patternfly-build commented Mar 26, 2026

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Bug - Menu - initially drilled in menu height incorrect

3 participants