feat(card): add isGlass prop#12290
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
WalkthroughThe Card component now accepts an optional Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~8 minutes 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
Preview: https://pf-react-pr-12290.surge.sh A11y report: https://pf-react-pr-12290-a11y.surge.sh |
| isFullHeight?: boolean; | ||
| /** Modifies the card to include plain styling; this removes border and background */ | ||
| isPlain?: boolean; | ||
| /** Modifies the card to include glass styling */ |
There was a problem hiding this comment.
would it be worth clarifying that it'll include glass styling when the glass contrast mode is enabled?
thatblindgeye
left a comment
There was a problem hiding this comment.
Speaking with Coker + Nicole's above comment
Co-authored-by: Eric Olkowski <70952936+thatblindgeye@users.noreply.github.com>
|
Your changes have been released in:
Thanks for your contribution! 🎉 |
What: Closes #12268
Additional issues:
Assisted by Claude Code
Summary by CodeRabbit
New Features
Tests