Skip to content

fix(Popper): add null & connected checks for document [6.4.x patch]#12286

Open
kmcfaul wants to merge 2 commits intopatternfly:6.4.xfrom
kmcfaul:6.4-popper-documentcheck
Open

fix(Popper): add null & connected checks for document [6.4.x patch]#12286
kmcfaul wants to merge 2 commits intopatternfly:6.4.xfrom
kmcfaul:6.4-popper-documentcheck

Conversation

@kmcfaul
Copy link
Copy Markdown
Contributor

@kmcfaul kmcfaul commented Mar 23, 2026

What: Closes #12255

Adds a fallback to window.document for getDocumentElement.ts and adds isConnected checks for useIsomorphicLayoutEffect before createPopper is called.

@coderabbitai
Copy link
Copy Markdown

coderabbitai bot commented Mar 23, 2026 •
edited
Loading

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: bc7d425e-ca32-48fe-8ae0-d9da410fcc8b

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@patternfly-build
Copy link
Copy Markdown
Collaborator

patternfly-build commented Mar 23, 2026 •
edited
Loading

Preview: https://pf-react-pr-12286.surge.sh

A11y report: https://pf-react-pr-12286-a11y.surge.sh

@dlabaj
chore: sync yarn.lock with registry metadata for react-router
0d33466 
Yarn hardened mode on public PRs rejects a lockfile that lists stale
dependencies for react-router@7.13.0. Refresh the lockfile so
`yarn install --immutable` succeeds in CI.

Made-with: Cursor
dlabaj
dlabaj approved these changes Mar 23, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor

@dlabaj dlabaj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dlabaj dlabaj dlabaj approved these changes

@thatblindgeye thatblindgeye thatblindgeye approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@kmcfaul @patternfly-build @dlabaj @thatblindgeye