Use safe instead of .replace() for percent-encoding#224
Open
Yannic wants to merge 1 commit intopackage-url:mainfrom
Open
Use safe instead of .replace() for percent-encoding#224Yannic wants to merge 1 commit intopackage-url:mainfrom
safe instead of .replace() for percent-encoding#224Yannic wants to merge 1 commit intopackage-url:mainfrom
Conversation
Note that this incorrectly classifies `/` as safe character when it should be encoded for backward compatibility with the existing test suite. It seems like the spec testsuite may be inconsistent whether `/` should be encoded or not (e.g., Bazel does while Maven doesn't).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note that this incorrectly classifies
/as safe character when it should be encoded for backward compatibility with the existing test suite. We should fix that in a follow-up.