Some small fixups and rearrangements to previous commit#732
Merged
jafingerhut merged 1 commit intomasterfrom Mar 19, 2026
Merged
Some small fixups and rearrangements to previous commit#732jafingerhut merged 1 commit intomasterfrom
jafingerhut merged 1 commit intomasterfrom
Conversation
Signed-off-by: Andy Fingerhut <andy_fingerhut@alum.wustl.edu>
Contributor
|
Thank you for the quick fixes, explanations, and adjustments @jafingerhut @Dscano The log folder issue is fixed. I see that the Makefile test now has dirs to make all the directories. I just pulled the latest upstream changes to my P4 VM and verified that make test now correctly recreates the logs/ directory after a make clean. Everything is working smoothly now. 
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.