feat: encryption keys location can be specified by the storage implementation by DeepDiver1975 · Pull Request #39348 · owncloud/core

DeepDiver1975 · 2021-10-12T10:00:50Z

Description

This allows storage implementations to specify the location for encryption keys
https://github.com/owncloud/files_spaces needs this because the space does not belong to a user.

Related Issue

Fixes https://github.com/owncloud/enterprise/issues/4687
alternative approach to feat: encryption keys location can be specified by the storage implementation #39091

Types of changes

Bug fix (non-breaking change which fixes an issue)
New feature (non-breaking change which adds functionality)
Database schema changes (next release will require increase of minor version instead of patch)
Breaking change (fix or feature that would cause existing functionality to change)
Technical debt
Tests only (no source changes)

Checklist:

mmattel · 2021-10-12T18:18:57Z

I know that the PR is in an early stage, but remember if it gets glose to merge if a docs issue is necessary... 😄

ownclouders · 2021-10-20T08:57:52Z

💥 Acceptance tests pipeline apiVersions-mariadb10.2-php7.4 failed. The build has been cancelled.

https://drone.owncloud.com/owncloud/core/33159/85/1

cdamken · 2021-10-22T14:21:03Z

I know that the PR is in an early stage, but remember if it gets glose to merge if a docs issue is necessary... 😄

At least to have an appropriate description, to have an easy way to follow what is going to be done

IljaN · 2021-10-22T15:30:48Z

lib/public/Encryption/IEncryptionModule.php

 	 * @since 8.1.0
 	 */
-	public function begin($path, $user, $mode, array $header, array $accessList, $sourceFileOfRename);
+	public function begin($path, $user, $mode, array $header, array $accessList, $sourceFileOfRename, $fileEncryptionVersion);


Won't this break existing implementations of the interface?

Technically we are probably the only implementors?

Yes - this is a BC break. We need to be careful with releasing this and make sure encryption module is properly release together with it.

@micbar FYI

necessary change in encryption owncloud/encryption#307

Is E2EE App maybe using this interface?

sonarqubecloud · 2021-10-26T10:05:58Z

Kudos, SonarCloud Quality Gate passed!

0 Bugs
0 Vulnerabilities
0 Security Hotspots
6 Code Smells

80.2% Coverage
0.0% Duplication

ownclouders · 2021-12-01T11:20:38Z

💥 Acceptance tests pipeline cliEncryption-mariadb10.2-php7.4 failed. The build has been cancelled.

https://drone.owncloud.com/owncloud/core/33855/120/1

DeepDiver1975 · 2021-12-01T15:56:34Z

a specific branch of the encryption app is required

mmattel · 2021-12-05T10:22:28Z

This is docs relevant, please file a docs issue wheh close to merge.

ownclouders · 2021-12-07T09:10:05Z

💥 Acceptance tests pipeline cliEncryption-mariadb10.2-php7.4 failed. The build has been cancelled.

https://drone.owncloud.com/owncloud/core/33941/120/1

ownclouders · 2021-12-07T09:27:16Z

💥 Acceptance tests pipeline apiProxySmoke-8-3-mariadb10.2-php7.4 failed. The build has been cancelled.

https://drone.owncloud.com/owncloud/core/33941/172/1

ownclouders · 2021-12-15T09:40:31Z

💥 Acceptance tests pipeline cliEncryption-mariadb10.2-php7.4 failed. The build has been cancelled.

https://drone.owncloud.com/owncloud/core/34037/120/1

ownclouders · 2022-01-11T15:37:44Z

💥 Acceptance tests pipeline cliEncryption-mariadb10.2-php7.4 failed. The build has been cancelled.

https://drone.owncloud.com/owncloud/core/34278/120/1

…entation

…torage

…has no own key handling

…lves

ownclouders · 2022-02-14T14:49:20Z

💥 Acceptance tests pipeline cliEncryption-mariadb10.2-php7.4 failed. The build has been cancelled.

https://drone.owncloud.com/owncloud/core/34637/120/1

ownclouders · 2022-03-07T14:53:09Z

💥 Acceptance tests pipeline cliEncryption-mariadb10.2-php7.4 failed. The build has been cancelled.

https://drone.owncloud.com/owncloud/core/34827/120/1

DeepDiver1975 · 2024-11-19T07:55:16Z

cleaning up - I think this is no longer of anybody's interest

DeepDiver1975 force-pushed the feat/storage-based-encryption-key-location-2 branch 2 times, most recently from 349f008 to 80be5cb Compare October 19, 2021 14:57

DeepDiver1975 mentioned this pull request Oct 19, 2021

feat: decrypt versions on IVersionedStorage owncloud/encryption#307

Open

DeepDiver1975 force-pushed the feat/storage-based-encryption-key-location-2 branch 3 times, most recently from 89689e7 to 4bc4c36 Compare October 20, 2021 06:50

DeepDiver1975 force-pushed the feat/storage-based-encryption-key-location-2 branch 3 times, most recently from 1a3af2f to 96b5f39 Compare October 20, 2021 14:16

IljaN reviewed Oct 22, 2021

View reviewed changes

DeepDiver1975 changed the title ~~Feat/storage based encryption key location 2~~ feat: encryption keys location can be specified by the storage implementation Oct 26, 2021

DeepDiver1975 marked this pull request as ready for review October 26, 2021 07:20

DeepDiver1975 force-pushed the feat/storage-based-encryption-key-location-2 branch from e9c105e to 15066a3 Compare October 29, 2021 12:03

DeepDiver1975 force-pushed the feat/storage-based-encryption-key-location-2 branch 3 times, most recently from 830d394 to 592638f Compare December 1, 2021 11:07

DeepDiver1975 force-pushed the feat/storage-based-encryption-key-location-2 branch from f084e60 to ff502e1 Compare December 15, 2021 09:27

DeepDiver1975 force-pushed the feat/storage-based-encryption-key-location-2 branch from ff502e1 to da3fcdc Compare January 11, 2022 15:19

IljaN force-pushed the feat/storage-based-encryption-key-location-2 branch from da3fcdc to 74a2bf5 Compare January 11, 2022 15:22

DeepDiver1975 and others added 11 commits February 14, 2022 15:39

feat: encryption keys location can be specified by the storage implem…

2d6b1ea

…entation

feat: decrypt the stream of a file version as returned by IVersionedS…

ffbfa89

…torage

fix: encryption storage wrapper will only delete keys if the storage …

17d5166

…has no own key handling

Add unit tests for versioned storage methods

902d140

fix: handle encryption keys with trashbin

6fc1a33

feat: add before_moveToTrash hook + add fileId to delete hook

fae49b3

feat: adding new storage method getFileKey

57d8174

feat: adding new storage method setFileKey

3f7a7bb

fix: trashbin pre_restore hook and encryption version on move

6ead2dc

feat: versioned storages are expected to handle retainVersions themse…

395f24f

…lves

fix: handle file rename properly

ec45392

DeepDiver1975 force-pushed the feat/storage-based-encryption-key-location-2 branch from 74a2bf5 to ec45392 Compare February 14, 2022 14:40

IljaN changed the base branch from master to release-10.9.1 February 24, 2022 16:25

IljaN changed the base branch from release-10.9.1 to master February 24, 2022 16:25

feat: copy trashed items to all owner trash bins

dedb089

feat: detect collisions of mounts wit local files

43c67b7

DeepDiver1975 force-pushed the feat/storage-based-encryption-key-location-2 branch from 49326aa to 43c67b7 Compare March 29, 2022 13:34

feat: add absolute paths to rename hook

1a9a0d1

DeepDiver1975 changed the base branch from master to 10.9.x July 27, 2023 07:22

DeepDiver1975 changed the base branch from 10.9.x to master July 27, 2023 07:22

phil-davis mentioned this pull request Sep 5, 2023

feat: encryption keys location can be specified by the storage implementation #40973

Closed

11 tasks

DeepDiver1975 closed this Nov 19, 2024

DeepDiver1975 deleted the feat/storage-based-encryption-key-location-2 branch November 19, 2024 07:55

Comments

Conversation

DeepDiver1975 commented Oct 12, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Related Issue

Types of changes

Checklist:

Uh oh!

mmattel commented Oct 12, 2021

Uh oh!

ownclouders commented Oct 20, 2021

Uh oh!

cdamken commented Oct 22, 2021

Uh oh!

IljaN Oct 22, 2021

Choose a reason for hiding this comment

Uh oh!

IljaN Oct 22, 2021

Choose a reason for hiding this comment

Uh oh!

DeepDiver1975 Oct 26, 2021

Choose a reason for hiding this comment

Uh oh!

DeepDiver1975 Oct 26, 2021

Choose a reason for hiding this comment

Uh oh!

IljaN Oct 26, 2021

Choose a reason for hiding this comment

Uh oh!

sonarqubecloud bot commented Oct 26, 2021

Uh oh!

ownclouders commented Dec 1, 2021

Uh oh!

DeepDiver1975 commented Dec 1, 2021

Uh oh!

mmattel commented Dec 5, 2021

Uh oh!

ownclouders commented Dec 7, 2021

Uh oh!

ownclouders commented Dec 7, 2021

Uh oh!

ownclouders commented Dec 15, 2021

Uh oh!

ownclouders commented Jan 11, 2022

Uh oh!

ownclouders commented Feb 14, 2022

Uh oh!

ownclouders commented Mar 7, 2022

Uh oh!

DeepDiver1975 commented Nov 19, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

DeepDiver1975 commented Oct 12, 2021 •

edited

Loading