Conversation
|
@cardil: The label(s) DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: cardil The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
/cc @dsimansk |
|
@cardil thanks! Can you check if it doesn't break release-next branch when event plugin is not present pls? I can probably try out tomorrow as well if you don't get to it. |
Oh, yeah. It will probably break it. However, maybe we can make the script optional. If kn-event isn't found in go.mod than skip the settings... Let me see /hold |
To avoid things like #281
/kind feature