refactor: Remove no-op ENABLE_FORUM_DAILY_DIGEST definition#38245
Open
kdmccormick wants to merge 2 commits intomasterfrom
Open
refactor: Remove no-op ENABLE_FORUM_DAILY_DIGEST definition#38245kdmccormick wants to merge 2 commits intomasterfrom
kdmccormick wants to merge 2 commits intomasterfrom
Conversation
This line was likely added here with the intent of defining an edx-toggles-style FeatureToggle object. Instead, it just declares a local variable named ENABLE_FORUM_DAILY_DIGEST, whereas the actual check occurs at either of: * settings.ENABLE_FORUM_DAILY_DIGEST # new way * settings.FEATURES['ENABLE_FORUM_DAILY_DIGEST'] # old way The toggle annotation has already been correctly updated to reflect that the toggle default is effectively False.
kdmccormick
referenced
this pull request
Mar 30, 2026
The ENABLE_FORUM_DAILY_DIGEST config was using both a Django Setting and a waffle flag. This consolidates this to simply use the single Django Setting: FEATURES['ENABLE_FORUM_DAILY_DIGEST']. ARCHBOM-132
robrap
reviewed
Mar 30, 2026
|
|
||
| def is_forum_daily_digest_enabled(): | ||
| """Returns whether forum notification features should be visible""" | ||
| return settings.FEATURES.get('ENABLE_FORUM_DAILY_DIGEST', False) |
Contributor
There was a problem hiding this comment.
I think it might be best to just move the toggle annotations above this line, inside the method. Thoughts?
robrap
approved these changes
Mar 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This line was likely added here with the intent of defining an edx-toggles-style FeatureToggle object. Instead, it just declares a local variable named ENABLE_FORUM_DAILY_DIGEST, whereas the actual check occurs at either of:
The local variable can be safely removed, reducing confusion.
The toggle annotation has already been correctly updated to reflect that the toggle default is effectively False.
Original context: e7e1a40#commitcomment-179325396
I discovered this while working on larger refactoring of the FEATURES dictionary: #38095