Skip to content

Remove XModuleMixin legacy attibs from wordcloud, video block, lti block#38220

Merged
farhan merged 2 commits intomasterfrom
farhan/remove-legacy-attribs
Mar 31, 2026
Merged

Remove XModuleMixin legacy attibs from wordcloud, video block, lti block#38220
farhan merged 2 commits intomasterfrom
farhan/remove-legacy-attribs

Conversation

@farhan
Copy link
Copy Markdown
Contributor

@farhan farhan commented Mar 26, 2026 •
edited
Loading

It's the PR to fix the test cases for this xblocks-contrib PR: openedx/xblocks-contrib#204

PR on disabled blocks has been created to verify the test cases in disabled state:
#38221

Testing notes:
Following things has been tested on the sandbox of this PR for Video, WordCloud & LTI block:

  1. Block is working fine on studio, lms, content library
  2. We can copy/paste the block
  3. We can add a block from the content library
  4. Video editor is working fine
  5. Transcripts for videos are uploading, deleting and working fine on the video editor
  6. Different format (mp4, hls, youtube ..) video formats are working fine for the video formats
  7. Import/Export of the course having these blocks has been tested

Detailed test document team follows: document

@farhan farhan mentioned this pull request Mar 26, 2026
Merged
@farhan farhan added the create-sandbox open-craft-grove should create a sandbox environment from this PR label Mar 26, 2026
@farhan farhan changed the title Remove XModuleMixin legacy attibs from extracted wordcloud, video, lti block TEST PR | Don't merge | extracted wordcloud, video, lti block Mar 27, 2026
@farhan farhan changed the title TEST PR | Don't merge | extracted wordcloud, video, lti block WIP PR | Remove XModuleMixin legacy attibs from wordcloud, video block, lti block Mar 27, 2026
@farhan farhan force-pushed the farhan/remove-legacy-attribs branch 2 times, most recently from 59d4456 to 99c86f3 Compare March 30, 2026 11:02
github-actions bot and others added 2 commits March 30, 2026 16:10
@github-actions @farhan
feat: Upgrade Python dependency xblocks-contrib (#38234)
5287ce7 
Commit generated by workflow `openedx/openedx-platform/.github/workflows/upgrade-one-python-dependency.yml@refs/heads/farhan/remove-legacy-attribs`

Co-authored-by: farhan <25842457+farhan@users.noreply.github.com>
@farhan
fix: test cases fixing
2210e58
@farhan farhan force-pushed the farhan/remove-legacy-attribs branch from 99c86f3 to 2210e58 Compare March 30, 2026 11:11
@farhan farhan marked this pull request as ready for review March 30, 2026 11:54
@farhan farhan changed the title WIP PR | Remove XModuleMixin legacy attibs from wordcloud, video block, lti block Remove XModuleMixin legacy attibs from wordcloud, video block, lti block Mar 30, 2026
@farhan farhan merged commit 51a7b4b into master Mar 31, 2026
53 checks passed
@farhan farhan deleted the farhan/remove-legacy-attribs branch March 31, 2026 08:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@salman2013 salman2013 salman2013 approved these changes

@irtazaakram irtazaakram Awaiting requested review from irtazaakram irtazaakram is a code owner

Assignees

No one assigned

Labels

create-sandbox open-craft-grove should create a sandbox environment from this PR

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@farhan @salman2013