fix: use KeyManagerFactory.getDefaultAlgorithm() in TlsUtil.keyManager()#8122
Merged
jkwatson merged 1 commit intoopen-telemetry:mainfrom Feb 28, 2026
Merged
fix: use KeyManagerFactory.getDefaultAlgorithm() in TlsUtil.keyManager()#8122jkwatson merged 1 commit intoopen-telemetry:mainfrom
jkwatson merged 1 commit intoopen-telemetry:mainfrom
Conversation
TlsUtil.keyManager() was incorrectly using TrustManagerFactory.getDefaultAlgorithm() to initialize KeyManagerFactory, which could cause NoSuchAlgorithmException. Fixes open-telemetry#8112
|
|
Member
|
Can you sign the CLA? Thanks! |
jack-berg
approved these changes
Feb 27, 2026
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #8122 +/- ##
============================================
+ Coverage 90.33% 90.34% +0.01%
- Complexity 7614 7647 +33
============================================
Files 839 841 +2
Lines 22913 23007 +94
Branches 2285 2295 +10
============================================
+ Hits 20698 20786 +88
- Misses 1505 1507 +2
- Partials 710 714 +4 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TlsUtil.keyManager() was incorrectly using TrustManagerFactory.getDefaultAlgorithm() to initialize KeyManagerFactory, which could cause NoSuchAlgorithmException.
Fixes #8112