feat: adding gh changelog/releases within npmx#1233
feat: adding gh changelog/releases within npmx#1233WilcoSp wants to merge 85 commits intonpmx-dev:mainfrom
Conversation
…md -> html does need to change)
|
The latest updates on your projects. Learn more about Vercel for GitHub.
1 Skipped Deployment
|
Lunaria Status Overview🌕 This pull request will trigger status changes. Learn moreBy default, every PR changing files present in the Lunaria configuration's You can change this by adding one of the keywords present in the Tracked Files
Warnings reference
|
Codecov Report❌ Patch coverage is 📢 Thoughts on this report? Let us know! |
excludes changelog releases due to needing api calls
|
for releases it's now also matching on the version in a release title https://npmxdev-git-fork-wilcosp-feat-changelog-1-npmx.vercel.app/package-changes/nuxt/v/3.20.0 I've also added that if there was already a route hash present that it'll navigate to it when releases have been fetched to ensure that the scrolling happens |
|
@danielroe I've now added to both releases & changelog.md that npmx will scroll to the version if possible. examples for releases
examples for changelog.md |
|
What I've also noticed is with Vite & Pinia's sub packages the changelog.md aren't correctly fetched. for both come from the latest release. what might be a solution is to also use the repository directory so that the changelog.md can only be either at the root or in the directory. also for fetching without releases I'll then also expand to use the directory. but this can be in a different pr, but I'll leave it up to you Daniel. Also I did notice that ungh.css doesn't give all releases but a selection and it also doesn't support pagination. Also for a future pr I do plan to use useRouteParams from vueuse to have the switching between versions perform better and prevent needing to refetch the releases/changelog.md again if it's the same between versions. |
|
I've just fixed how the changelog is resolved for vite and other monorepos with changelog.md but the repository.directory does need to be defined, else it'll be the same as the already existing behavior. |
|
I've also noticed with at least Turkish & Czech that "view on npm" & "view on github" can differ, so the "view on {site}" that I've made might not work. I'll ask in the i18n channel in discord what the best solution will be as it'll also be needed for other git providers. for changelog in pr 2 but it's also needed for the package page when readme.md can't be loaded. |
… back releases title's will now use slugify instead of encodeUri to fix issues with encoding
|
I've merged the main branch and updated to use "common.view_on.*" translations. unless issues are found I won't add more to this PR and leave it to review & to merge into main |
|
I wanted to have a look, but I'm not sure in what env to check. I looked at:
I'm not sure how previews are working by PR in vercel. Maybe there is a latest link to be used? |
|
@jycouet I advice using https://npmxdev-git-fork-wilcosp-feat-changelog-1-npmx.vercel.app/package-changes/svelte/v/5.53.8 for the changelogs not showing it might be an issue with ungh.cc which is atm the github ap that's being used |
This pr will add the possibility to view the changelog.md & releases from a package's github repo within npmx.
This will make it easier to see the changelogs while not needing to leave npmx and allowing quicker access.
This pr is the first pr of #501
Preview here
While I was making this PR antfu also made this pr #1368 and here my comment from his pr