Skip to content

test: capture negative utimes mtime at call time #62490

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
inoway46 wants to merge 1 commit into
base: main
Choose a base branch
from
+17 −6
Open

test: capture negative utimes mtime at call time #62490

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 17 additions & 6 deletions test/parallel/test-fs-utimes.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -70,6 +70,11 @@ function expect_ok(syscall, resource, err, atime, mtime, statSync) {
);
}

function getExpectedMtime(mtime) {
// Negative numeric timestamps are normalized to "now" at call time.
return fs._toUnixTimestamp(mtime);
}

Copy link
Copy Markdown
Contributor Author

@inoway46 inoway46 Mar 29, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This helper is optional and I can inline it if preferred.

I kept it as a helper because the key point is to capture the expected mtime at call time before each invocation, and I thought naming that step made the intent clearer.

const stats = fs.statSync(tmpdir.path);

const asPath = (path) => path;
Expand Down Expand Up @@ -98,11 +103,13 @@ function runTests(iter) {
//
// test async code paths
//
const expectedUtimesMtime = getExpectedMtime(mtime);
fs.utimes(pathType(tmpdir.path), atime, mtime, common.mustCall((err) => {
expect_ok('utimes', tmpdir.path, err, atime, mtime);
expect_ok('utimes', tmpdir.path, err, atime, expectedUtimesMtime);

const expectedLutimesMtime = getExpectedMtime(mtime);
fs.lutimes(pathType(lpath), atime, mtime, common.mustCall((err) => {
expect_ok('lutimes', lpath, err, atime, mtime, fs.lstatSync);
expect_ok('lutimes', lpath, err, atime, expectedLutimesMtime, fs.lstatSync);

fs.utimes(pathType('foobarbaz'), atime, mtime, common.mustCall((err) => {
expect_errno('utimes', 'foobarbaz', err, 'ENOENT');
Expand All @@ -114,8 +121,9 @@ function runTests(iter) {
fd = fs.openSync(tmpdir.path, 'r');
}

const expectedFutimesMtime = getExpectedMtime(mtime);
fs.futimes(fd, atime, mtime, common.mustCall((err) => {
expect_ok('futimes', fd, err, atime, mtime);
expect_ok('futimes', fd, err, atime, expectedFutimesMtime);

syncTests();

Expand All @@ -129,17 +137,20 @@ function runTests(iter) {
// test synchronized code paths, these functions throw on failure
//
function syncTests() {
const expectedUtimesMtime = getExpectedMtime(mtime);
fs.utimesSync(pathType(tmpdir.path), atime, mtime);
expect_ok('utimesSync', tmpdir.path, undefined, atime, mtime);
expect_ok('utimesSync', tmpdir.path, undefined, atime, expectedUtimesMtime);

const expectedLutimesMtime = getExpectedMtime(mtime);
fs.lutimesSync(pathType(lpath), atime, mtime);
expect_ok('lutimesSync', lpath, undefined, atime, mtime, fs.lstatSync);
expect_ok('lutimesSync', lpath, undefined, atime, expectedLutimesMtime, fs.lstatSync);

// Some systems don't have futimes
// if there's an error, it should be ENOSYS
try {
const expectedFutimesMtime = getExpectedMtime(mtime);
fs.futimesSync(fd, atime, mtime);
expect_ok('futimesSync', fd, undefined, atime, mtime);
expect_ok('futimesSync', fd, undefined, atime, expectedFutimesMtime);
} catch (ex) {
expect_errno('futimesSync', fd, ex, 'ENOSYS');
}
Expand Down
Loading