Skip to content

lib: fix typo in esm worker loader hook comment#62475

Merged
aduh95 merged 1 commit intonodejs:mainfrom
jakecastelli:fix-lib-worker-typo-asynchronous
Mar 28, 2026
Merged

lib: fix typo in esm worker loader hook comment#62475
aduh95 merged 1 commit intonodejs:mainfrom
jakecastelli:fix-lib-worker-typo-asynchronous

Conversation

@jakecastelli
Copy link
Copy Markdown
Member

No description provided.

@jakecastelli jakecastelli added the fast-track PRs that do not need to wait for 72 hours to land. label Mar 28, 2026
@nodejs-github-bot
Copy link
Copy Markdown
Collaborator

Review requested:

  • @nodejs/loaders

@github-actions
Copy link
Copy Markdown
Contributor

Fast-track has been requested by @jakecastelli. Please 👍 to approve.

@nodejs-github-bot nodejs-github-bot added esm Issues and PRs related to the ECMAScript Modules implementation. needs-ci PRs that need a full CI run. labels Mar 28, 2026
@codecov
Copy link
Copy Markdown

codecov bot commented Mar 28, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 89.68%. Comparing base (cf2b05c) to head (cd082ce).
⚠️ Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #62475      +/-   ##
==========================================
- Coverage   89.70%   89.68%   -0.02%     
==========================================
  Files         691      691              
  Lines      213943   213943              
  Branches    41039    41051      +12     
==========================================
- Hits       191909   191876      -33     
- Misses      14089    14137      +48     
+ Partials     7945     7930      -15     
Files with missing lines Coverage Δ
lib/internal/modules/esm/worker.js 91.84% <100.00%> (ø)

... and 26 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@lpinca lpinca added the request-ci Add this label to start a Jenkins CI on a PR. label Mar 28, 2026
@aduh95 aduh95 added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. and removed needs-ci PRs that need a full CI run. request-ci Add this label to start a Jenkins CI on a PR. labels Mar 28, 2026
@aduh95 aduh95 merged commit 7ed2fdf into nodejs:main Mar 28, 2026
47 checks passed
@aduh95
Copy link
Copy Markdown
Contributor

aduh95 commented Mar 28, 2026

Landed in 7ed2fdf

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

author ready PRs that have at least one approval, no pending requests for changes, and a CI started. esm Issues and PRs related to the ECMAScript Modules implementation. fast-track PRs that do not need to wait for 72 hours to land.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants