Skip to content

src: add contextify interceptor debug logs#62460

Open
legendecas wants to merge 2 commits intonodejs:mainfrom
legendecas:vm-debug
Open

src: add contextify interceptor debug logs#62460
legendecas wants to merge 2 commits intonodejs:mainfrom
legendecas:vm-debug

Conversation

@legendecas
Copy link
Copy Markdown
Member

Add debug logs to help investigate vm interceptor call order issues like
#61898 (comment)

The format of the V8 values are conditional by the presence of
NODE_DEBUG_NATIVE. So these values are not always converted to c++
values by utilizing per_process::Debug debuglog.

@nodejs-github-bot nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. lib / src Issues and PRs related to general changes in the lib or src directory. needs-ci PRs that need a full CI run. labels Mar 27, 2026
@legendecas legendecas added the vm Issues and PRs related to the vm subsystem. label Mar 27, 2026
@codecov
Copy link
Copy Markdown

codecov bot commented Mar 27, 2026

Codecov Report

❌ Patch coverage is 40.90909% with 13 lines in your changes missing coverage. Please review.
✅ Project coverage is 89.69%. Comparing base (38647b3) to head (4656e6a).
⚠️ Report is 5 commits behind head on main.

Files with missing lines Patch % Lines
src/debug_utils-inl.h 0.00% 13 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #62460      +/-   ##
==========================================
- Coverage   89.71%   89.69%   -0.02%     
==========================================
  Files         676      678       +2     
  Lines      206751   207282     +531     
  Branches    39645    39754     +109     
==========================================
+ Hits       185482   185920     +438     
- Misses      13403    13461      +58     
- Partials     7866     7901      +35     
Files with missing lines Coverage Δ
src/debug_utils.h 80.00% <ø> (ø)
src/node_contextify.cc 82.59% <100.00%> (+0.13%) ⬆️
src/debug_utils-inl.h 76.37% <0.00%> (-8.71%) ⬇️

... and 34 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Copy Markdown
Member

@joyeecheung joyeecheung left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

c++ Issues and PRs that require attention from people who are familiar with C++. lib / src Issues and PRs related to general changes in the lib or src directory. needs-ci PRs that need a full CI run. vm Issues and PRs related to the vm subsystem.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants