Skip to content

module: runtime deprecate module.register()#62401

Open
GeoffreyBooth wants to merge 1 commit intonodejs:mainfrom
GeoffreyBooth:runtime-deprecate-module-register
Open

module: runtime deprecate module.register()#62401
GeoffreyBooth wants to merge 1 commit intonodejs:mainfrom
GeoffreyBooth:runtime-deprecate-module-register

Conversation

@GeoffreyBooth
Copy link
Copy Markdown
Member

@GeoffreyBooth GeoffreyBooth commented Mar 23, 2026

Building on #62395, this runtime-deprecates module.register().

I’m not sure when we want to land and release this; I think the options are basically either:

  1. When module.registerHooks() goes stable, hopefully sometime before 26 goes LTS; module: doc-deprecate module.register() #62395 (comment)
  2. In 26.0.0; the doc-deprecation is backported to the 25.x line, and the runtime deprecation is 26+; module: doc-deprecate module.register() #62395 (comment)

I’m opening this now in case the team wants to do the second option. cc @nodejs/loaders @nodejs/userland-migrations

@GeoffreyBooth GeoffreyBooth added the loaders Issues and PRs related to ES module loaders label Mar 23, 2026
@nodejs-github-bot
Copy link
Copy Markdown
Collaborator

nodejs-github-bot commented Mar 23, 2026

Review requested:

  • @nodejs/loaders
  • @nodejs/userland-migrations

@nodejs-github-bot nodejs-github-bot added esm Issues and PRs related to the ECMAScript Modules implementation. needs-ci PRs that need a full CI run. labels Mar 23, 2026
@GeoffreyBooth GeoffreyBooth force-pushed the runtime-deprecate-module-register branch from c5ce15e to 77638cb Compare March 23, 2026 03:18
@GeoffreyBooth GeoffreyBooth added dont-land-on-v20.x PRs that should not land on the v20.x-staging branch and should not be released in v20.x. dont-land-on-v22.x PRs that should not land on the v22.x-staging branch and should not be released in v22.x. dont-land-on-v24.x PRs that should not land on the v24.x-staging branch and should not be released in v24.x. dont-land-on-v25.x PRs that should not land on the v25.x-staging branch and should not be released in v25.x. labels Mar 23, 2026
@GeoffreyBooth GeoffreyBooth force-pushed the runtime-deprecate-module-register branch from 77638cb to 1a08254 Compare March 23, 2026 03:51
@codecov
Copy link
Copy Markdown

codecov bot commented Mar 23, 2026 •
edited
Loading

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 89.71%. Comparing base (7ffbb76) to head (a0e36fb).
⚠️ Report is 7 commits behind head on main.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main   #62401   +/-   ##
=======================================
  Coverage   89.70%   89.71%           
=======================================
  Files         692      692           
  Lines      214039   214051   +12     
  Branches    41064    41067    +3     
=======================================
+ Hits       192010   192032   +22     
- Misses      14091    14108   +17     
+ Partials     7938     7911   -27
Files with missing lines Coverage Δ
lib/internal/modules/esm/loader.js 98.78% <100.00%> (+0.01%) ⬆️

... and 44 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

AugustinMauroy
AugustinMauroy reviewed Mar 23, 2026
View reviewed changes
Copy link
Copy Markdown
Member

@AugustinMauroy AugustinMauroy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In general that seem good.

mcollina
mcollina approved these changes Mar 23, 2026
View reviewed changes
Copy link
Copy Markdown
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

I think we should aim for 26.x, so we can actually drop in 27

aduh95
aduh95 reviewed Mar 23, 2026
View reviewed changes
@GeoffreyBooth GeoffreyBooth mentioned this pull request Mar 23, 2026
Closed
@GeoffreyBooth GeoffreyBooth added the tsc-agenda Issues and PRs to discuss during the meetings of the TSC. label Mar 23, 2026
@openjs-meetings-bot openjs-meetings-bot bot mentioned this pull request Mar 26, 2026
Open
mcollina
mcollina approved these changes Mar 29, 2026
View reviewed changes
Copy link
Copy Markdown
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

gurgunday
gurgunday approved these changes Mar 29, 2026
View reviewed changes
Copy link
Copy Markdown
Member

@gurgunday gurgunday left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@GeoffreyBooth GeoffreyBooth force-pushed the runtime-deprecate-module-register branch from 1a08254 to 2124d8a Compare March 29, 2026 16:47
@GeoffreyBooth GeoffreyBooth force-pushed the runtime-deprecate-module-register branch from 2124d8a to a0e36fb Compare March 29, 2026 16:56
@GeoffreyBooth GeoffreyBooth added the request-ci Add this label to start a Jenkins CI on a PR. label Mar 29, 2026
@github-actions github-actions bot added request-ci-failed An error occurred while starting CI via request-ci label, and manual interventon is needed. and removed request-ci Add this label to start a Jenkins CI on a PR. labels Mar 29, 2026
@github-actions

This comment was marked as outdated.

Sign in to view
mcollina
mcollina approved these changes Mar 29, 2026
View reviewed changes
Copy link
Copy Markdown
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@mcollina
Copy link
Copy Markdown
Member

mcollina commented Mar 29, 2026

@nodejs/tsc ptal. this should land for v26

@GeoffreyBooth GeoffreyBooth added request-ci Add this label to start a Jenkins CI on a PR. and removed request-ci-failed An error occurred while starting CI via request-ci label, and manual interventon is needed. labels Mar 29, 2026
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Mar 29, 2026
@nodejs-github-bot
Copy link
Copy Markdown
Collaborator

nodejs-github-bot commented Mar 29, 2026

CI: https://ci.nodejs.org/job/node-test-pull-request/72219/

@aduh95 aduh95 added the blocked PRs that are blocked by other issues or PRs. label Mar 29, 2026
@nodejs-github-bot
Copy link
Copy Markdown
Collaborator

nodejs-github-bot commented Mar 30, 2026

CI: https://ci.nodejs.org/job/node-test-pull-request/72286/

@nodejs-github-bot
Copy link
Copy Markdown
Collaborator

nodejs-github-bot commented Mar 30, 2026

CI: https://ci.nodejs.org/job/node-test-pull-request/72304/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@aduh95 aduh95 aduh95 left review comments

@mcollina mcollina mcollina approved these changes

@panva panva panva approved these changes

@himself65 himself65 himself65 approved these changes

@gurgunday gurgunday gurgunday approved these changes

@joyeecheung joyeecheung Awaiting requested review from joyeecheung

@legendecas legendecas Awaiting requested review from legendecas

+2 more reviewers

@AugustinMauroy AugustinMauroy AugustinMauroy left review comments

@jsumners-nr jsumners-nr jsumners-nr approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

blocked PRs that are blocked by other issues or PRs. dont-land-on-v20.x PRs that should not land on the v20.x-staging branch and should not be released in v20.x. dont-land-on-v22.x PRs that should not land on the v22.x-staging branch and should not be released in v22.x. dont-land-on-v24.x PRs that should not land on the v24.x-staging branch and should not be released in v24.x. dont-land-on-v25.x PRs that should not land on the v25.x-staging branch and should not be released in v25.x. esm Issues and PRs related to the ECMAScript Modules implementation. loaders Issues and PRs related to ES module loaders needs-ci PRs that need a full CI run. tsc-agenda Issues and PRs to discuss during the meetings of the TSC.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

9 participants

@GeoffreyBooth @nodejs-github-bot @mcollina @panva @himself65 @aduh95 @gurgunday @AugustinMauroy @jsumners-nr