Skip to content

lib: prefer primordials in SubtleCrypto#62226

Open
panva wants to merge 3 commits intonodejs:mainfrom
panva:test-webcrypto-thenable
Open

lib: prefer primordials in SubtleCrypto#62226
panva wants to merge 3 commits intonodejs:mainfrom
panva:test-webcrypto-thenable

Conversation

@panva
Copy link
Member

@panva panva commented Mar 12, 2026

No description provided.

@panva panva added the commit-queue-rebase Add this label to allow the Commit Queue to land a PR in several commits. label Mar 12, 2026
@nodejs-github-bot
Copy link
Collaborator

Review requested:

  • @nodejs/crypto

@nodejs-github-bot nodejs-github-bot added lib / src Issues and PRs related to general changes in the lib or src directory. needs-ci PRs that need a full CI run. labels Mar 12, 2026
@panva panva added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. request-ci Add this label to start a Jenkins CI on a PR. labels Mar 12, 2026
@codecov
Copy link

codecov bot commented Mar 12, 2026

Codecov Report

❌ Patch coverage is 91.30435% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 89.66%. Comparing base (e47df44) to head (1c6d567).
⚠️ Report is 5 commits behind head on main.

Files with missing lines Patch % Lines
lib/internal/crypto/ml_dsa.js 50.00% 1 Missing ⚠️
lib/internal/crypto/ml_kem.js 50.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #62226      +/-   ##
==========================================
- Coverage   89.68%   89.66%   -0.03%     
==========================================
  Files         676      676              
  Lines      206451   206456       +5     
  Branches    39523    39525       +2     
==========================================
- Hits       185161   185116      -45     
- Misses      13432    13459      +27     
- Partials     7858     7881      +23     
Files with missing lines Coverage Δ
lib/internal/crypto/cfrg.js 96.26% <100.00%> (+<0.01%) ⬆️
lib/internal/crypto/util.js 95.45% <100.00%> (ø)
lib/internal/crypto/webidl.js 98.33% <100.00%> (+<0.01%) ⬆️
lib/internal/crypto/ml_dsa.js 93.73% <50.00%> (+0.01%) ⬆️
lib/internal/crypto/ml_kem.js 90.41% <50.00%> (+0.03%) ⬆️

... and 34 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Mar 12, 2026
@nodejs-github-bot
Copy link
Collaborator

@nodejs-github-bot
Copy link
Collaborator

@aduh95 aduh95 added the request-ci Add this label to start a Jenkins CI on a PR. label Mar 12, 2026
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Mar 12, 2026
@nodejs-github-bot

This comment was marked as outdated.

@nodejs-github-bot

This comment was marked as outdated.

@nodejs-github-bot

This comment was marked as outdated.

@nodejs-github-bot

This comment was marked as outdated.

@nodejs-github-bot
Copy link
Collaborator

@nodejs-github-bot

This comment was marked as outdated.

@nodejs-github-bot
Copy link
Collaborator

@panva panva added the commit-queue Add this label to land a pull request using GitHub Actions. label Mar 13, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

author ready PRs that have at least one approval, no pending requests for changes, and a CI started. commit-queue Add this label to land a pull request using GitHub Actions. commit-queue-rebase Add this label to allow the Commit Queue to land a PR in several commits. lib / src Issues and PRs related to general changes in the lib or src directory. needs-ci PRs that need a full CI run.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants