Skip to content

⚒️🎨 Migrate conversation list to Composables#5989

Merged
AndyScherzinger merged 21 commits intomasterfrom
chore/noid/migrateConvListPartsToComposables
Mar 27, 2026
Merged

⚒️🎨 Migrate conversation list to Composables#5989
AndyScherzinger merged 21 commits intomasterfrom
chore/noid/migrateConvListPartsToComposables

Conversation

@AndyScherzinger
Copy link
Copy Markdown
Member

@AndyScherzinger AndyScherzinger commented Mar 20, 2026 •
edited
Loading

🖼️ Screenshots

🏚️ Before 🏡 After
dark_old Screenshot_20260324_200532
light_old Screenshot_20260324_200514
search_old search_new

🚧 TODO

  • review
  • fix
  • merge

🏁 Checklist

  • ⛑️ Tests (unit and/or integration) are included or not needed
  • 🔖 Capability is checked or not needed
  • 🔙 Backport requests are created or not needed: /backport to stable-xx.x
  • 📅 Milestone is set
  • 🌸 PR title is meaningful (if it should be in the changelog: is it meaningful to users?)

@AndyScherzinger AndyScherzinger added 2. developing Work in progress technical debt Technical issue labels Mar 20, 2026
@AndyScherzinger AndyScherzinger force-pushed the chore/noid/migrateConvListPartsToComposables branch 17 times, most recently from 9bdd4b0 to 2032114 Compare March 23, 2026 19:14
@AndyScherzinger AndyScherzinger changed the title ⚒️🎨 Migrate conv list parts to composables ⚒️🎨 Migrate conversation list to Composables Mar 23, 2026
@AndyScherzinger AndyScherzinger force-pushed the chore/noid/migrateConvListPartsToComposables branch 7 times, most recently from 224302d to 32c1724 Compare March 24, 2026 15:03
@AndyScherzinger AndyScherzinger added 3. to review Waiting for reviews design Related to the design and removed 2. developing Work in progress labels Mar 24, 2026
@AndyScherzinger
chore(conv-list): Migrate Shimmer to Composable
487cd52 
AI-assistant: Copilot 1.0.10 (Claude Sonnet 4.6)

Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
@AndyScherzinger
feat(conv-list): Migrate notification warning card to Composable
5d04940 
AI-assistant: Copilot 1.0.10 (Claude Sonnet 4.6)

Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
@AndyScherzinger
feat(conv-list): Migrate federation invitation card to Composable
283dcd4 
AI-assistant: Copilot 1.0.10 (Claude Sonnet 4.6)

Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
@AndyScherzinger
feat(conv-list): Create conversation item Composable
36c2094 
AI-assistant: Copilot 1.0.10 (Claude Sonnet 4.6)

Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
@AndyScherzinger
feat(conv-list): Create conversation list Composable
54a6b56 
AI-assistant: Copilot 1.0.10 (Claude Sonnet 4.6)

Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
@AndyScherzinger
style(conv-list): resize fab to properly show the drop shadow
ba563d9 
AI-assistant: Copilot 1.0.10 (Claude Sonnet 4.6)

Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
@AndyScherzinger
feat(conv-list): Migrate top bars to Composable
9ae89e8 
AI-assistant: Copilot 1.0.10 (Claude Sonnet 4.6)

Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
@AndyScherzinger
feat(conv-list): Migrate conversation list screen
5763c13 
AI-assistant: Copilot 1.0.10 (Claude Sonnet 4.6)

Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
@AndyScherzinger AndyScherzinger force-pushed the chore/noid/migrateConvListPartsToComposables branch from f40b1dd to 5763c13 Compare March 25, 2026 07:38
@mahibi
Copy link
Copy Markdown
Collaborator

mahibi commented Mar 25, 2026 •
edited by AndyScherzinger
Loading

  • Offline info at wrong position:
grafik
  • center horizontal for unread mentions text:
grafik
  • The loading bars overlay the conversation items for a moment after opening the list. They should be hidden earlier:
grafik

mahibi
mahibi previously requested changes Mar 25, 2026
View reviewed changes
Copy link
Copy Markdown
Collaborator

@mahibi mahibi left a comment •
edited by AndyScherzinger
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Strange behavior:
  1. when having many conversations, scroll down
  2. open a random conversation
  3. go back to conversation list
  4. scroll up and pull down to refresh

actual:
conversation list jumps to the last opened conversation

expected:
conversation list remains at top position

@mahibi
Copy link
Copy Markdown
Collaborator

mahibi commented Mar 25, 2026

really great!!!
Happy that FlexibleAdapter will soon be removed 🥳

@AndyScherzinger
style(unread): center button text and lower padding between icon and …
f79ed58 
…label

Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
@AndyScherzinger
style(conv-list): Move statusBarsPadding() from top bar to list scree…
46b4813 
…n to ensure all content is always below the status bar

Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
@AndyScherzinger
style(conv-list): Ensure shimmer is hidden before conversation items …
f64e8be 
…are shown

AI-assistant: Copilot 1.0.10 (Claude Sonnet 4.6)

Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
@AndyScherzinger
fix(conv-list): drop list position on pull-to-refresh and account swi…
459aa64 
…tching

AI-assistant: Copilot 1.0.10 (Claude Sonnet 4.6)

Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
@AndyScherzinger AndyScherzinger dismissed mahibi’s stale review March 25, 2026 13:30

All findings fixed

@AndyScherzinger AndyScherzinger requested a review from mahibi March 25, 2026 13:30
@AndyScherzinger
fix(conv-list): ensure shimmer is properly hidden quickly enough
86c7552 
AI-assistant: Copilot 1.0.10 (Claude Sonnet 4.6)

Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
@AndyScherzinger
fix(conv-list): center position on scrolling to unread, mentioned con…
37f73e1 
…versation

AI-assistant: Copilot 1.0.10 (Claude Sonnet 4.6)

Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
@AndyScherzinger
fix(unread): Ensure unread button is also initially on-updates shown …
ed1b95d 
…if needed

AI-assistant: Copilot 1.0.10 (Claude Sonnet 4.6)

Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
@AndyScherzinger
fix(unread): Don't restore scroll position when interaction with a co…
5147916 
…nveration (like makr as (un)read)

AI-assistant: Copilot 1.0.10 (Claude Sonnet 4.6)

Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Mar 25, 2026

Codacy

Lint

TypemasterPR
Warnings9394
Errors00

SpotBugs

CategoryBaseNew
Bad practice66
Correctness1010
Dodgy code5454
Internationalization33
Malicious code vulnerability33
Performance44
Security11
Total8181

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Mar 25, 2026

APK file: https://www.kaminsky.me/nc-dev/android-artifacts/5989.apk

qrcode

To test this change/fix you can simply download above APK file and install and test it in parallel to your existing Nextcloud app.

@AndyScherzinger AndyScherzinger added this to the 23.1.0 milestone Mar 26, 2026
@mahibi
Copy link
Copy Markdown
Collaborator

mahibi commented Mar 27, 2026

all reported bugs are fixed as far i can see.
Except the shimmer issue, but this is nothing that should block this PR and can be fixed in follow ups.

@AndyScherzinger AndyScherzinger merged commit 6742c7b into master Mar 27, 2026
16 of 17 checks passed
@AndyScherzinger AndyScherzinger deleted the chore/noid/migrateConvListPartsToComposables branch March 27, 2026 11:15
@mahibi mahibi mentioned this pull request Apr 2, 2026
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mahibi mahibi mahibi approved these changes

@nimishavijay nimishavijay Awaiting requested review from nimishavijay

Assignees

No one assigned

Labels

3. to review Waiting for reviews design Related to the design technical debt Technical issue

Projects

None yet

Milestone

24.0.0

Development

Successfully merging this pull request may close these issues.

2 participants

@AndyScherzinger @mahibi