Fix #56818: Toggle 2FA icons based on theme light/dark mode#59268
Open
carolinafquinteiro wants to merge 1 commit intonextcloud:masterfrom
Open
Fix #56818: Toggle 2FA icons based on theme light/dark mode#59268carolinafquinteiro wants to merge 1 commit intonextcloud:masterfrom
carolinafquinteiro wants to merge 1 commit intonextcloud:masterfrom
Conversation
The 2FA setup and backup code icons were not adapting correctly to different themes, leading to visibility issues. This fix replaces the single static icon with two separate icons: .two-factor-icon-light and .two-factor-icon-dark. It introduces a new SCSS file to toggle visibility based on: - The 'data-themes' attribute on the body (manual selection). - The 'prefers-color-scheme' media query (system default theme). Changes: - Modified 2FA PHP templates to include light and dark SVG versions. - Added twofactor-icons.scss to handle display:none/inline logic. - Registered the new stylesheet in the relevant 2FA views. Signed-off-by: Carolina Quinteiro <carolinafquinteiro@tecnico.ulisboa.pt>
susnux
reviewed
Mar 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The 2FA setup and backup code icons were not adapting correctly to different themes, leading to visibility issues.
This fix replaces the single static icon with two separate icons: .two-factor-icon-light and .two-factor-icon-dark. It introduces a new SCSS file to toggle visibility based on:
Changes:
Summary
TODO
Checklist
3. to review, feature component)stable32)AI (if applicable)