Skip to content

fix: add author.url to plugin.json#46

Merged
CybotTM merged 1 commit intomainfrom
fix/plugin-json-author-url
Mar 29, 2026
Merged

fix: add author.url to plugin.json#46
CybotTM merged 1 commit intomainfrom
fix/plugin-json-author-url

Conversation

@CybotTM
Copy link
Copy Markdown
Member

@CybotTM CybotTM commented Mar 29, 2026

Summary

  • Add "url": "https://www.netresearch.de" to the author object in plugin.json
  • Required by skill validation which checks for author.url

Test plan

  • CI skill validation passes

The skill validation requires author.url to be set to
https://www.netresearch.de in plugin.json.
@CybotTM CybotTM merged commit 4a38b99 into main Mar 29, 2026
5 checks passed
@CybotTM CybotTM deleted the fix/plugin-json-author-url branch March 29, 2026 08:25
Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request adds a url field to the author metadata in .claude-plugin/plugin.json. A review comment suggests removing the homepage field to eliminate redundancy and simplify future maintenance.

Comment on lines +9 to 10
"url": "https://www.netresearch.de",
"homepage": "https://www.netresearch.de/"
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

The homepage field is redundant now that the required url field is being added, as they both point to the same location. Having duplicate information can lead to maintenance issues (e.g., needing to update the URL in two places).

To improve clarity and maintainability, please remove the homepage field.

    "url": "https://www.netresearch.de"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant