fix: remove updating of legacy _DATABASE_SCEMA env variables in railway#1896
fix: remove updating of legacy _DATABASE_SCEMA env variables in railway#1896
Conversation
|
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: ASSERTIVE Plan: Pro Run ID: 📒 Files selected for processing (1)
💤 Files with no reviewable changes (1)
📝 WalkthroughWalkthroughRemoved five database schema variable configurations from a GitHub Actions deployment workflow, eliminating schema definitions for Alpha, Mainnet, and Sepolia network variants while retaining indexer-specific schema variables and other workflow logic intact. Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes Poem
🚥 Pre-merge checks | ✅ 2 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (2 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Greptile SummaryThis PR removes the setting of five legacy
Confidence Score: 5/5Safe to merge — removes stale legacy variable writes with no impact on current deployment logic. The change is a simple cleanup: six lines that upsert now-unused No files require special attention.
|
| Filename | Overview |
|---|---|
| .github/workflows/deploy_ensnode_blue_green.yml | Removes 5 legacy *_DATABASE_SCHEMA variable upsert calls; the equivalent *_ENSINDEXER_SCHEMA_NAME calls remain unchanged and continue to set identical values. |
Reviews (1): Last reviewed commit: "fix: remove updating of legact _DATABASE..." | Re-trigger Greptile
There was a problem hiding this comment.
Pull request overview
This PR updates the Railway blue/green deploy workflow to stop writing the legacy *_DATABASE_SCHEMA shared variables, relying only on the newer *_ENSINDEXER_SCHEMA_NAME variables going forward.
Changes:
- Removed
set_shared_variablecalls that upsertALPHA_DATABASE_SCHEMA,MAINNET_DATABASE_SCHEMA,ALPHA-SEPOLIA_DATABASE_SCHEMA,V2-SEPOLIA_DATABASE_SCHEMA, andSEPOLIA_DATABASE_SCHEMAin Railway. - Kept (and continues to set) the corresponding
*_ENSINDEXER_SCHEMA_NAMEshared variables based on the deployment tag.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
removes the setting of the
*_DATABASE_SCHEMAenv vars in railway now that future deploys will use the new_ENSINDEXER_SCHEMA_NAMEvars