Skip to content

fix: remove updating of legacy _DATABASE_SCEMA env variables in railway#1896

Merged
shrugs merged 1 commit intomainfrom
fix/remove-database-schema-env-updates
Apr 8, 2026
Merged

fix: remove updating of legacy _DATABASE_SCEMA env variables in railway#1896
shrugs merged 1 commit intomainfrom
fix/remove-database-schema-env-updates

Conversation

@shrugs
Copy link
Copy Markdown
Collaborator

@shrugs shrugs commented Apr 8, 2026

removes the setting of the *_DATABASE_SCHEMA env vars in railway now that future deploys will use the new _ENSINDEXER_SCHEMA_NAME vars

@changeset-bot
Copy link
Copy Markdown

changeset-bot bot commented Apr 8, 2026

⚠️ No Changeset found

Latest commit: 4ef7e60

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@shrugs shrugs requested a review from a team as a code owner April 8, 2026 16:38
Copilot AI review requested due to automatic review settings April 8, 2026 16:38
@vercel
Copy link
Copy Markdown
Contributor

vercel bot commented Apr 8, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
admin.ensnode.io Ready Ready Preview, Comment Apr 8, 2026 4:39pm
ensnode.io Ready Ready Preview, Comment Apr 8, 2026 4:39pm
ensrainbow.io Ready Ready Preview, Comment Apr 8, 2026 4:39pm

@shrugs shrugs changed the title fix: remove updating of legact _DATABASE_SCEMA env variables in railway fix: remove updating of legacy _DATABASE_SCEMA env variables in railway Apr 8, 2026
@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai bot commented Apr 8, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: ASSERTIVE

Plan: Pro

Run ID: 8a5fb5e8-e10b-46da-9a1e-b5a5f32afde2

📥 Commits

Reviewing files that changed from the base of the PR and between 0cc51b3 and 4ef7e60.

📒 Files selected for processing (1)
  • .github/workflows/deploy_ensnode_blue_green.yml
💤 Files with no reviewable changes (1)
  • .github/workflows/deploy_ensnode_blue_green.yml

📝 Walkthrough

Walkthrough

Removed five database schema variable configurations from a GitHub Actions deployment workflow, eliminating schema definitions for Alpha, Mainnet, and Sepolia network variants while retaining indexer-specific schema variables and other workflow logic intact.

Changes

Cohort / File(s) Summary
Workflow Configuration
.github/workflows/deploy_ensnode_blue_green.yml
Deleted five set_shared_variable calls that configured database schema variables (ALPHA_DATABASE_SCHEMA, MAINNET_DATABASE_SCHEMA, ALPHA-SEPOLIA_DATABASE_SCHEMA, V2-SEPOLIA_DATABASE_SCHEMA, SEPOLIA_DATABASE_SCHEMA). Indexer schema variables remain unchanged.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Poem

🐰 Database schemas took flight today,
Five variables removed, they hop away,
The indexer schemas stay put and true,
Cleaner workflows, streamlined through and through! ✨

🚥 Pre-merge checks | ✅ 2 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Description check ⚠️ Warning The PR description is missing the required template structure with Summary, Why, Testing, and Pre-Review Checklist sections. Follow the repository's PR template by adding Summary, Why, Testing, and Pre-Review Checklist sections with appropriate details.
✅ Passed checks (2 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly summarizes the main change: removing legacy database schema environment variable updates in Railway deployment workflow.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix/remove-database-schema-env-updates

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@greptile-apps
Copy link
Copy Markdown
Contributor

greptile-apps bot commented Apr 8, 2026

Greptile Summary

This PR removes the setting of five legacy *_DATABASE_SCHEMA environment variables (ALPHA_DATABASE_SCHEMA, MAINNET_DATABASE_SCHEMA, ALPHA-SEPOLIA_DATABASE_SCHEMA, V2-SEPOLIA_DATABASE_SCHEMA, SEPOLIA_DATABASE_SCHEMA) from the Railway blue-green deployment workflow, now that future deploys rely exclusively on the newer *_ENSINDEXER_SCHEMA_NAME variables.

  • Removes six lines from .github/workflows/deploy_ensnode_blue_green.yml that called set_shared_variable with the old schema naming convention.
  • The newer *_ENSINDEXER_SCHEMA_NAME variables (already present) continue to be set with the same values.
  • No logic, sequencing, or other workflow steps are affected.

Confidence Score: 5/5

Safe to merge — removes stale legacy variable writes with no impact on current deployment logic.

The change is a simple cleanup: six lines that upsert now-unused *_DATABASE_SCHEMA variables are deleted. The replacement *_ENSINDEXER_SCHEMA_NAME variables (same values) are already being set immediately after. No logic, ordering, or other steps are altered, and no new code is introduced.

No files require special attention.

Vulnerabilities

No security concerns identified.

Important Files Changed

Filename Overview
.github/workflows/deploy_ensnode_blue_green.yml Removes 5 legacy *_DATABASE_SCHEMA variable upsert calls; the equivalent *_ENSINDEXER_SCHEMA_NAME calls remain unchanged and continue to set identical values.

Reviews (1): Last reviewed commit: "fix: remove updating of legact _DATABASE..." | Re-trigger Greptile

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates the Railway blue/green deploy workflow to stop writing the legacy *_DATABASE_SCHEMA shared variables, relying only on the newer *_ENSINDEXER_SCHEMA_NAME variables going forward.

Changes:

  • Removed set_shared_variable calls that upsert ALPHA_DATABASE_SCHEMA, MAINNET_DATABASE_SCHEMA, ALPHA-SEPOLIA_DATABASE_SCHEMA, V2-SEPOLIA_DATABASE_SCHEMA, and SEPOLIA_DATABASE_SCHEMA in Railway.
  • Kept (and continues to set) the corresponding *_ENSINDEXER_SCHEMA_NAME shared variables based on the deployment tag.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copy link
Copy Markdown
Member

@lightwalker-eth lightwalker-eth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@shrugs Looks good 👍

@shrugs shrugs merged commit de6f4d9 into main Apr 8, 2026
23 of 24 checks passed
@shrugs shrugs deleted the fix/remove-database-schema-env-updates branch April 8, 2026 19:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants