Skip to content

fix(mongodb-server-log-checker): ignore warnings from internal clients #627

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
paula-stacho merged 1 commit into from
Mar 23, 2026
Merged

fix(mongodb-server-log-checker): ignore warnings from internal clients #627

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 19 additions & 2 deletions packages/mongodb-server-log-checker/src/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@ export type WarningFilter = number | ((entry: LogEntry) => boolean);
* Monitors MongoDB server logs and validates that no unexpected warnings occur.
* Modeled after the mongosh implementation in PR #2574.
*/
export class ServerLogsChecker {
export class ServerLogsChecker implements Disposable {
static defaultAllowedWarnings: WarningFilter[] = [
4615610, // "Failed to check socket connectivity", generic disconnect error
7012500, // "Failed to refresh query analysis configurations", normal sharding behavior
Expand Down Expand Up @@ -93,6 +93,7 @@ export class ServerLogsChecker {
private collectedWarnings: LogEntry[] = [];
private warningFilters: ((entry: LogEntry) => boolean)[] = [];
private cluster: MongoLogEventEmitter;
private ignoreCtx: Set<string> = new Set();

constructor(cluster: MongoLogEventEmitter) {
this.cluster = cluster;
Expand All @@ -106,9 +107,20 @@ export class ServerLogsChecker {
}

private listener: (serverUUID: string, entry: LogEntry) => void = (
_serverUUID: string,
serverUUID: string,
entry: LogEntry,
) => {
const crossServerCtxID = `${serverUUID}\0${entry.context}`;
// Ignore events coming from internal clients (e.g. replset clients)
if (
entry.id === 51800 &&
entry.attr?.doc?.driver?.name === 'MongoDB Internal Client' &&
entry.context.startsWith('conn')
) {
this.ignoreCtx.add(crossServerCtxID);
}
if (this.ignoreCtx.has(crossServerCtxID)) return;

// Only collect warnings (W), errors (E), and fatal (F) severity logs
// Apply filters at collection time - filtered warnings are never stored
if (
Expand Down Expand Up @@ -173,4 +185,9 @@ export class ServerLogsChecker {
close(): void {
this.cluster.off('mongoLog', this.listener);
}

/** Disposable alias for close() */
[Symbol.dispose](): void {
this.close();
}
}
Loading