Skip to content

fix: misc fixes #5584

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
tdgao merged 8 commits into from
Mar 16, 2026
Merged

fix: misc fixes #5584

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
a4f1b6d
fix: PATs editing bug #4908
tdgao Mar 16, 2026
43a2322
fix: gallery edit do not do falsy check on title and description
tdgao Mar 16, 2026
1346e0b
feat: add aspect ratio on gallery images
tdgao Mar 16, 2026
21a5762
change aspect ratio to 16:9
tdgao Mar 16, 2026
73d8cb6
fix: mobile nav bar #5580
tdgao Mar 16, 2026
ee0fa36
use css::after instead for navbar fix
tdgao Mar 16, 2026
0534162
adjust after content to fix thin line
tdgao Mar 16, 2026
12dc1db
add save area inset for transform
tdgao Mar 16, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 12 additions & 1 deletion apps/frontend/src/layouts/default.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1279,7 +1279,7 @@ const { cycle: changeTheme } = useTheme()
left: 0;
background-color: var(--color-raised-bg);
z-index: 11; // 20 = modals, 10 = svg icons
transform: translateY(100%);
transform: translateY(calc(100% + env(safe-area-inset-bottom)));
transition: transform 0.4s cubic-bezier(0.54, 0.84, 0.42, 1);
border-radius: var(--size-rounded-card) var(--size-rounded-card) 0 0;
box-shadow: 0 0 20px 2px rgba(0, 0, 0, 0);
Expand Down Expand Up @@ -1367,6 +1367,17 @@ const { cycle: changeTheme } = useTheme()
border-top: 2px solid rgba(0, 0, 0, 0);
box-sizing: border-box;

&::after {
content: '';
position: absolute;
bottom: 2px;
left: 0;
width: 100%;
height: 300px;
background-color: var(--color-raised-bg);
transform: translateY(100%);
}

&.expanded {
box-shadow: none;
border-radius: 0;
Expand Down
8 changes: 4 additions & 4 deletions apps/frontend/src/pages/[type]/[id].vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2071,10 +2071,10 @@ const createGalleryItemMutation = useMutation({
file.type.split('/')[file.type.split('/').length - 1]
}&featured=${featured ?? false}`

if (title) {
if (title != null) {
url += `&title=${encodeURIComponent(title)}`
}
if (description) {
if (description != null) {
url += `&description=${encodeURIComponent(description)}`
}
if (ordering !== null && ordering !== undefined) {
Expand Down Expand Up @@ -2132,10 +2132,10 @@ const editGalleryItemMutation = useMutation({
mutationFn: async ({ projectId, imageUrl, title, description, featured, ordering }) => {
let url = `project/${projectId}/gallery?url=${encodeURIComponent(imageUrl)}&featured=${featured ?? false}`

if (title) {
if (title != null) {
url += `&title=${encodeURIComponent(title)}`
}
if (description) {
if (description != null) {
url += `&description=${encodeURIComponent(description)}`
}
if (ordering !== null && ordering !== undefined) {
Expand Down
6 changes: 3 additions & 3 deletions apps/frontend/src/pages/[type]/[id]/gallery.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -524,8 +524,8 @@ async function editGalleryItem() {
const imageUrl = filteredGallery.value[editIndex.value].url
const success = await contextEditGalleryItem(
imageUrl,
editTitle.value || undefined,
editDescription.value || undefined,
editTitle.value,
editDescription.value,
editFeatured.value,
editOrder.value ? Number(editOrder.value) : undefined,
)
Expand Down Expand Up @@ -723,7 +723,7 @@ async function deleteGalleryImage() {
margin-bottom: 0;
border-radius: var(--size-rounded-card) var(--size-rounded-card) 0 0;

min-height: 10rem;
aspect-ratio: 16 / 9;
object-fit: cover;
}

Expand Down
6 changes: 3 additions & 3 deletions apps/frontend/src/pages/[type]/[id]/settings/gallery.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -427,8 +427,8 @@ const editGalleryItem = async () => {

const success = await editGalleryItemMutation(
filteredGallery.value[editIndex.value].url,
editTitle.value || undefined,
editDescription.value || undefined,
editTitle.value,
editDescription.value,
editFeatured.value,
editOrder.value ?? undefined,
)
Expand Down Expand Up @@ -643,7 +643,7 @@ onUnmounted(() => {
margin-bottom: 0;
border-radius: var(--size-rounded-card) var(--size-rounded-card) 0 0;

min-height: 10rem;
aspect-ratio: 16 / 9;
object-fit: cover;
}

Expand Down
14 changes: 7 additions & 7 deletions apps/frontend/src/pages/settings/pats.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@
<Modal
ref="patModal"
:header="
editPatIndex !== null
editPatId !== null
? formatMessage(createModalMessages.editTitle)
: formatMessage(createModalMessages.createTitle)
"
Expand Down Expand Up @@ -58,7 +58,7 @@
{{ formatMessage(commonMessages.cancelButton) }}
</button>
<button
v-if="editPatIndex !== null"
v-if="editPatId !== null"
:disabled="loading || !name || !expires"
type="button"
class="iconified-button brand-button"
Expand Down Expand Up @@ -92,7 +92,7 @@
name = null
scopesVal = 0
expires = null
editPatIndex = null
editPatId = null
$refs.patModal.show()
}
"
Expand All @@ -109,7 +109,7 @@
</template>
</IntlFormatted>
</p>
<div v-for="(pat, index) in displayPats" :key="pat.id" class="universal-card recessed token">
<div v-for="pat in displayPats" :key="pat.id" class="universal-card recessed token">
<div>
<div>
<strong>{{ pat.name }}</strong>
Expand Down Expand Up @@ -162,7 +162,7 @@
class="iconified-button raised-button"
@click="
() => {
editPatIndex = index
editPatId = pat.id
name = pat.name
scopesVal = pat.scopes
expires = $dayjs(pat.expires).format('YYYY-MM-DD')
Expand Down Expand Up @@ -316,7 +316,7 @@ const data = useNuxtApp()
const { scopesToLabels } = useScopes()
const patModal = ref()

const editPatIndex = ref(null)
const editPatId = ref(null)

const name = ref(null)
const scopesVal = ref(BigInt(0))
Expand Down Expand Up @@ -415,7 +415,7 @@ async function editPat() {
startLoading()
loading.value = true
try {
await useBaseFetch(`pat/${pats.value[editPatIndex.value].id}`, {
await useBaseFetch(`pat/${editPatId.value}`, {
method: 'PATCH',
body: {
name: name.value,
Expand Down
Loading