Skip to content

fix: add Transfer-Encoding header to SSE responses for HTTP/2 compati… #1620

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
tinynakji wants to merge 1 commit into
base: main
Choose a base branch
from
+15 −3
Open

fix: add Transfer-Encoding header to SSE responses for HTTP/2 compati… #1620

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 15 additions & 3 deletions packages/server/src/server/streamableHttp.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -450,7 +450,11 @@ export class WebStandardStreamableHTTPServerTransport implements Transport {
const headers: Record<string, string> = {
'Content-Type': 'text/event-stream',
'Cache-Control': 'no-cache, no-transform',
Connection: 'keep-alive'
Connection: 'keep-alive',
// Ensures chunked transfer encoding for SSE streams. Some HTTP adapters
// (e.g., @hono/node-server) buffer small responses and add Content-Length,
// which causes HTTP/2 PROTOCOL_ERROR when the stream closes.
'Transfer-Encoding': 'chunked'
};

// After initialization, always include the session ID if we have one
Expand Down Expand Up @@ -503,7 +507,11 @@ export class WebStandardStreamableHTTPServerTransport implements Transport {
const headers: Record<string, string> = {
'Content-Type': 'text/event-stream',
'Cache-Control': 'no-cache, no-transform',
Connection: 'keep-alive'
Connection: 'keep-alive',
// Prevents @hono/node-server from buffering small responses and adding
// Content-Length, which causes HTTP/2 PROTOCOL_ERROR on stream close.
// See: https://github.com/honojs/node-server/blob/main/src/listener.ts#L463-L491
'Transfer-Encoding': 'chunked'
};

if (this.sessionId !== undefined) {
Expand Down Expand Up @@ -751,7 +759,11 @@ export class WebStandardStreamableHTTPServerTransport implements Transport {
const headers: Record<string, string> = {
'Content-Type': 'text/event-stream',
'Cache-Control': 'no-cache',
Connection: 'keep-alive'
Connection: 'keep-alive',
// Prevents @hono/node-server from buffering small responses and adding
// Content-Length, which causes HTTP/2 PROTOCOL_ERROR on stream close.
// See: https://github.com/honojs/node-server/blob/main/src/listener.ts#L463-L491
'Transfer-Encoding': 'chunked'
};

// After initialization, always include the session ID if we have one
Expand Down
Loading