fix(client): accumulate scopes across 401/403 auth challenges#1618
Closed
stakeswky wants to merge 1 commit intomodelcontextprotocol:mainfrom
Closed
fix(client): accumulate scopes across 401/403 auth challenges#1618stakeswky wants to merge 1 commit intomodelcontextprotocol:mainfrom
stakeswky wants to merge 1 commit intomodelcontextprotocol:mainfrom
Conversation
|
@modelcontextprotocol/client
@modelcontextprotocol/server
@modelcontextprotocol/express
@modelcontextprotocol/hono
@modelcontextprotocol/node
commit: |
Member
|
hi thanks for this, going to close this in favor of #1604 |
Member
|
hi thanks for this, going to close this in favor of #1604 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
union) scopes from newWWW-Authenticatechallenges instead of overwriting existing scopeinsufficient_scopeupscopingWhy
Servers with per-operation scopes may return only the scope needed for the current resource (RFC 6750). Overwriting client scope causes previously granted scopes to be dropped and can lead to re-authorization loops.
Fixes #1582.