Fix simulate() returning 0 for unfailed components#158
Open
Chessing234 wants to merge 1 commit intomitmath:Fall24from
Open
Fix simulate() returning 0 for unfailed components#158Chessing234 wants to merge 1 commit intomitmath:Fall24from
Chessing234 wants to merge 1 commit intomitmath:Fall24from
Conversation
Components that never fail within max_steps were left with v[i,j]=0, incorrectly suggesting they failed at time 0. Initialize with max_steps instead, so unfailed components are distinguishable from those that failed early.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
simulatefunction insimulating_component_failure.jlto initialize the grid withmax_stepsinstead of0max_stepsinstead of0, which previously made them appear as if they failed at time 0Fixes #154.
Test plan
simulation .< tt) works correctly with the new values