fix: ensure folding icons are clickable in sticky scroll#293559
Open
kairosci wants to merge 1 commit intomicrosoft:mainfrom
Open
fix: ensure folding icons are clickable in sticky scroll#293559kairosci wants to merge 1 commit intomicrosoft:mainfrom
kairosci wants to merge 1 commit intomicrosoft:mainfrom
Conversation
Add z-index and pointer-events to folding icons in sticky scroll to ensure they are always clickable and appear above other elements. This fixes an issue where folding controls would not respond to clicks when in the sticky scroll area. Fixes microsoft#292042
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes an editor UI issue where folding controls in the sticky scroll header could be visually obscured and/or not receive click events when a foldable region becomes part of the sticky scroll area.
Changes:
- Increase stacking priority of folding icons within sticky scroll via
z-index. - Ensure folding icons present the correct interaction affordance and can receive pointer input via
cursor: pointerandpointer-events: auto.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add z-index and pointer-events to folding icons in sticky scroll to ensure they are always clickable and appear above other elements.
This fixes an issue where folding controls would either disappear from the line margin or appear but not respond to clicks when a foldable region entered the sticky scroll area.
Fixes #292042