Skip to content

Implement LSP contract for Semantic Tokens#223

Draft
mattmasson wants to merge 9 commits intomasterfrom
semanticTokensLSP
Draft

Implement LSP contract for Semantic Tokens#223
mattmasson wants to merge 9 commits intomasterfrom
semanticTokensLSP

Conversation

@mattmasson
Copy link
Member

Attempt to implement semantic token parsing using the LSP API - #217

Before:
image

After:
image

However, I'm not sure if it is working as expected as the "Developer: Inspect Editor Tokens and Scope" only seems to show semantic token info for the as keyword.

image

test script:

section foo;

myfunc = (table as table, param as record, optional hello) =>
    let
        a = table,
        b = hello
    in
        a;

This PR builds on #222 (which should get merged first).

@mattmasson mattmasson requested a review from JordanBoltonMN May 23, 2024 03:29
trace.exit({ vscodeMessage });
}

export function isCancellationError(value: unknown): boolean {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Use this signature instead:
export function isCancellationError(value: unknown): value is PQP.CommonError.CancellationError

Also, would it be useful to add a isCancellationError to PQP?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants