Implement LSP contract for Semantic Tokens#223
Draft
mattmasson wants to merge 9 commits intomasterfrom
Draft
Conversation
added 2 commits
May 22, 2024 23:32
… into semanticTokensLSP
| trace.exit({ vscodeMessage }); | ||
| } | ||
|
|
||
| export function isCancellationError(value: unknown): boolean { |
Contributor
There was a problem hiding this comment.
Use this signature instead:
export function isCancellationError(value: unknown): value is PQP.CommonError.CancellationError
Also, would it be useful to add a isCancellationError to PQP?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Attempt to implement semantic token parsing using the LSP API - #217
Before:

After:

However, I'm not sure if it is working as expected as the "Developer: Inspect Editor Tokens and Scope" only seems to show semantic token info for the
askeyword.test script:
This PR builds on #222 (which should get merged first).