Add telemetry comment and errorCount metric for connection removal#399
Merged
tnaum-ms merged 2 commits intodev/tnaum/connection-multi-deletefrom Nov 24, 2025
Merged
Conversation
Co-authored-by: tnaum-ms <171359267+tnaum-ms@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Fix user connection removal functionality and add comments
Add telemetry comment and errorCount metric for connection removal
Nov 21, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses feedback on #398 regarding telemetry handling when multiple connection deletions fail.
Changes
errorCountmetric to telemetry measurements to provide context on total failure countThe
errorCountmetric is a derived value but adds useful context alongside the existingconnectionsToDeleteandconnectionsDeletedmeasurements.✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.