Conversation
… migration option
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR finalizes the migration plugins integration by replacing the chooseDataMigrationExtension command with a new accessDataMigrationServices command and introduces an internal plugin registry for better client verification and announced provider support.
- Command Migration: Replaces
chooseDataMigrationExtensionwithaccessDataMigrationServicesthroughout the extension - Enhanced Provider Support: Adds support for announced migration providers with marketplace integration
- Client Registration: Introduces verified client tracking and automatic registration via internal commands
Reviewed Changes
Copilot reviewed 9 out of 10 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
src/services/migrationServices.ts |
Adds client extension registration and announced provider listing functionality |
src/extension.ts |
Adds internal command for client registration and updates API version |
src/documentdb/ClustersExtension.ts |
Updates command registration to use new migration services command |
src/commands/chooseDataMigrationExtension/chooseDataMigrationExtension.ts |
Removes old command implementation |
src/commands/accessDataMigrationServices/accessDataMigrationServices.ts |
Implements new command with marketplace integration and announced providers |
package.json |
Updates command references, adds announced providers config, and renames client verification fields |
l10n/bundle.l10n.json |
Adds localization string for client registration |
api/src/utils/getApi.ts |
Updates client verification logic and adds automatic registration |
api/package.json |
Bumps API version to 0.3.0 |
Files not reviewed (1)
- api/package-lock.json: Language not supported
src/commands/accessDataMigrationServices/accessDataMigrationServices.ts
Outdated
Show resolved
Hide resolved
src/commands/accessDataMigrationServices/accessDataMigrationServices.ts
Outdated
Show resolved
Hide resolved
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
…egration-and-introduce-a-plugin-registry
Collaborator
Author
|
It is ready for the release 🚀. Waiting for a confirmation from the migration team. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request introduces several updates focused on improving the data migration provider system and refining client extension verification for the VS Code DocumentDB extension. The changes include renaming and restructuring API configuration fields, updating command references, and adding support for announced migration providers. The most significant update is the addition of a new command handler for accessing data migration services, which enhances the user experience for selecting and interacting with migration providers.
Introduces an always visible context menu item for
Data Migration....The context menu item activates a QuickPick with a list of supported migration providers (this list can be extended):
Data Migration Provider Improvements
accessDataMigrationServicesinsrc/commands/accessDataMigrationServices/accessDataMigrationServices.tsto present users with a quick pick for installed and announced migration providers, including marketplace integration and authentication handling.package.jsonfromchooseDataMigrationExtensiontoaccessDataMigrationServicesfor all relevant UI actions, ensuring the new handler is used throughout the extension. [1] [2] [3]package.jsonunder the newx-announcedMigrationProvidersfield, allowing the extension to surface marketplace providers to users.API Configuration and Client Verification Updates
package.jsonandapi/src/utils/getApi.tsfromregisteredClientstoverifiedClients, and updated logic to check for verified clients when authorizing API access. [1] [2] [3]getDocumentDBExtensionApiby adding an internal command call to register the client extension, with error handling and logging for registration failures.Miscellaneous
0.2.0to0.3.0in bothapi/package.jsonandapi/package-lock.jsonto reflect these significant updates. [1] [2]l10n/bundle.l10n.json.