fix: improve error message when createTester base lacks package.json#10033
Open
jaxx2104 wants to merge 2 commits intomicrosoft:mainfrom
Open
fix: improve error message when createTester base lacks package.json#10033jaxx2104 wants to merge 2 commits intomicrosoft:mainfrom
jaxx2104 wants to merge 2 commits intomicrosoft:mainfrom
Conversation
…kage.json Previously, createTester would throw a generic file-not-found error when the base directory did not contain a package.json. This adds a clear, actionable error message indicating that the first argument must be the library root directory.
jaxx2104
requested review from
AlitzelMendez,
bterlson,
chrisradek,
markcowl,
timotheeguerin and
witemple-msft
as code owners
microsoft-github-policy-service
bot
added
the
compiler:core
Author
|
@microsoft-github-policy-service agree |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #9597
Summary
createTesteris called with a base directory that does not contain apackage.json, the error was a generic file-not-found. This change catches the error and throws a clear, actionable message indicating the first argument must be the library root directory.Test plan
package.jsonis missing from the base directory.