Add OriginalName to InputOperation to prevent CollectionResult name collisions#10021
Merged
jorgerangel-msft merged 11 commits intomainfrom Mar 13, 2026
Merged
Conversation
…esultDefinition.BuildName Co-authored-by: jorgerangel-msft <102122018+jorgerangel-msft@users.noreply.github.com>
Co-authored-by: jorgerangel-msft <102122018+jorgerangel-msft@users.noreply.github.com>
...nerator/Microsoft.TypeSpec.Generator.ClientModel/src/Providers/CollectionResultDefinition.cs
Outdated
Show resolved
Hide resolved
...or.ClientModel/test/Providers/CollectionResultDefinitions/CollectionResultDefinitionTests.cs
Outdated
Show resolved
Hide resolved
Copilot
AI
changed the title
[WIP] Fix CollectionResults type name collisions
Add OriginalName to InputOperation to prevent CollectionResult name collisions
Mar 13, 2026
...-client-csharp/generator/Microsoft.TypeSpec.Generator.Input/src/InputTypes/InputOperation.cs
Outdated
Show resolved
Hide resolved
…ion and no-collision tests Co-authored-by: jorgerangel-msft <102122018+jorgerangel-msft@users.noreply.github.com>
…sync+async × 2 ops) Co-authored-by: jorgerangel-msft <102122018+jorgerangel-msft@users.noreply.github.com>
Co-authored-by: jorgerangel-msft <102122018+jorgerangel-msft@users.noreply.github.com>
...nerator/Microsoft.TypeSpec.Generator.ClientModel/src/Providers/CollectionResultDefinition.cs
Show resolved
Hide resolved
Co-authored-by: jorgerangel-msft <102122018+jorgerangel-msft@users.noreply.github.com>
Co-authored-by: jorgerangel-msft <102122018+jorgerangel-msft@users.noreply.github.com>
...-client-csharp/generator/Microsoft.TypeSpec.Generator.Input/src/InputTypes/InputOperation.cs
Outdated
Show resolved
Hide resolved
…r and test factory Co-authored-by: jorgerangel-msft <102122018+jorgerangel-msft@users.noreply.github.com>
...-client-csharp/generator/Microsoft.TypeSpec.Generator.Input/src/InputTypes/InputOperation.cs
Outdated
Show resolved
Hide resolved
Co-authored-by: jorgerangel-msft <102122018+jorgerangel-msft@users.noreply.github.com>
Co-authored-by: jorgerangel-msft <102122018+jorgerangel-msft@users.noreply.github.com>
Contributor
Author
|
Just as a heads up, I was blocked by some firewall rules while working on your feedback. Expand below for details. Warning Firewall rules blocked me from connecting to one or more addresses (expand for details)I tried to connect to the following addresses, but was blocked by firewall rules:
If you need me to access, download, or install something from one of these locations, you can either:
|
commit: |
JoshLove-msft
approved these changes
Mar 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CollectionResultDefinition.BuildName()derives its type name fromOperation.Name, which is mutable viaInputOperation.Update(). When multiple operations get renamed to the same name (e.g.,ListandListAllboth becomingGetAllviaCleanOperationNames), their CollectionResult types collide.BuildName()now detects collisions by checking if another paging operation in the same client would produce the same name, and only falls back toOriginalNamewhen a collision is detected. When there is no collision, the current (cleaned) name is used as before.Changes
InputOperation— Added nullableOriginalNameproperty (string?), never modified byUpdate(), with no default assignmentInputOperationConverter— SetOriginalNameduring deserialization (sole assignment point for production code)ClientProvider— Exposed_inputClientas aninternal InputClientproperty soCollectionResultDefinitioncan access the client's methods for collision detectionCollectionResultDefinition.BuildName()— AddedHasPagingOperationNameCollision()check; usesOriginalName(with null fallback toOperation.Name) only when another paging operation in the same client would produce the same nameCollectionResultDefinitionTests— Added collision test (two opslist+listAllboth renamed toGetAllproduce unique names) and no-collision test (single op uses cleaned name)InputFactory— Updated test factory to explicitly setOriginalNameafter constructionOriginal prompt
💬 Send tasks to Copilot coding agent from Slack and Teams to turn conversations into code. Copilot posts an update in your thread when it's finished.