Skip to content

Conversation

@benkeen
Copy link
Contributor

@benkeen benkeen commented Jan 31, 2026

Addresses: #5578

Right now, when you update packages in a Rush/pnpm repo using rush-pnpm up, it updates the catalog entries in common/temp/pnpm-workspace.yaml, but doesn't update Rush's actual catalog, stored in pnpm-config.json, so the update command doesn't fully work. This has been supported since pnpm@10.12.0. This PR enhances it to update the pnpm-config file too.

I also updated it to fix a small issue where JsonFile.save could throw an error due to an undefined $schema property.

Besides the tests, I've ran manual checks with our own Rush repo to confirm the catalog is getting updated properly.

@benkeen
Copy link
Contributor Author

benkeen commented Feb 5, 2026

Howdy @iclanton, @dmichon-msft - don't suppose either of you have context or time to look at this?

@iclanton iclanton moved this from Needs triage to In Progress in Bug Triage Feb 9, 2026
@iclanton
Copy link
Member

iclanton commented Feb 9, 2026

Shouldn't users be running rush update instead of rush-pnpm update?

@benkeen
Copy link
Contributor Author

benkeen commented Feb 9, 2026

Huh, neat. I never associated those two commands in my mind.

rush update has a very limited, custom interface for Rush itself. What I'm trying to do is offer up all the extra options with pnpm update, for updating subsets of dependencies, like:

pnpm update -r "@babel/*"

That could always be done with rush-pnpm (but not rush update); this PR just lets that command handle catalogs too.

Tell me if I'm being barmy.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: In Progress

Development

Successfully merging this pull request may close these issues.

2 participants