Skip to content

Comments

chore(bidi): fix fragment navigations#39263

Merged
Skn0tt merged 1 commit intomicrosoft:mainfrom
hbenl:fragment-navigation
Feb 13, 2026
Merged

chore(bidi): fix fragment navigations#39263
Skn0tt merged 1 commit intomicrosoft:mainfrom
hbenl:fragment-navigation

Conversation

@hbenl
Copy link
Collaborator

@hbenl hbenl commented Feb 13, 2026

BidiPage.navigateFrame() shouldn't return a newDocumentId for fragment navigations. We detect them by storing the navigation IDs of browsingContext.fragmentNavigated events, which are always sent before the result of the browsingContext.navigate command.

Fixes the following tests:

  • page/frame-hierarchy.spec.ts
    • "should send "framenavigated" when navigating on anchor URLs"
  • page/page-goto.spec.ts
    • "should work with anchor navigation"

@hbenl hbenl force-pushed the fragment-navigation branch from ddf4139 to db13a1e Compare February 13, 2026 14:17
@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@github-actions
Copy link
Contributor

Test results for "tests 1"

5 failed
❌ [playwright-test] › expect.spec.ts:542 › should respect expect.timeout in toHaveURL @macos-latest-node20
❌ [playwright-test] › reporter.spec.ts:251 › created › should not have internal error when steps are finished after timeout @macos-latest-node20
❌ [playwright-test] › reporter.spec.ts:251 › merged › should not have internal error when steps are finished after timeout @macos-latest-node20
❌ [playwright-test] › ui-mode-test-network-tab.spec.ts:371 › should not preserve selection across test runs @macos-latest-node20
❌ [playwright-test] › reporter-html.spec.ts:636 › created › should show trace title @windows-latest-node20

3 flaky ⚠️ [chromium-library] › library/inspector/cli-codegen-3.spec.ts:226 › cli codegen › should generate frame locators (4) `@chromium-ubuntu-22.04-node24`
⚠️ [firefox-library] › library/beforeunload.spec.ts:188 › does not get stalled by beforeUnload `@firefox-ubuntu-22.04-node20`
⚠️ [firefox-library] › library/inspector/cli-codegen-1.spec.ts:1082 › cli codegen › should not throw csp directive violation errors `@firefox-ubuntu-22.04-node20`

38536 passed, 843 skipped


Merge workflow run.

@github-actions
Copy link
Contributor

Test results for "MCP"

1 failed
❌ [chrome] › mcp/launch.spec.ts:21 › test reopen browser @mcp-macos-15

4804 passed, 135 skipped


Merge workflow run.

@Skn0tt Skn0tt merged commit e956d6e into microsoft:main Feb 13, 2026
30 of 34 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants