unconditionally define decl exports for GNU-style visibility#637
Open
eli-schwartz wants to merge 1 commit intomicrosoft:devfrom
Open
unconditionally define decl exports for GNU-style visibility#637eli-schwartz wants to merge 1 commit intomicrosoft:devfrom
eli-schwartz wants to merge 1 commit intomicrosoft:devfrom
Conversation
Unlike on Windows, it is perfectly acceptable to set symbol visibility for static libraries, and it magically works. In fact, it even beneficially does something useful. This simplifies the code by avoiding special cases.
Contributor
|
Could it result in the mimalloc symbols being visible when a mimalloc static library is linked into some shared library? |
Collaborator
|
.. I am unsure about the consequences of this -- but I like simpler code :-). Can an expert weigh in? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Unlike on Windows, it is perfectly acceptable to set symbol visibility for static libraries, and it magically works. In fact, it even beneficially does something useful.
This simplifies the code by avoiding special cases.