add support for static override on Windows#1075
Open
Noxybot wants to merge 1 commit intomicrosoft:devfrom
Open
add support for static override on Windows#1075Noxybot wants to merge 1 commit intomicrosoft:devfrom
Noxybot wants to merge 1 commit intomicrosoft:devfrom
Conversation
Collaborator
|
I don't think this can really work? Nowadays, one should link with the universal C runtime library which is a DLL so there is no way to statically override the allocator (unless I guess we link to a static CRT -- is that the use case that you envision?). |
Contributor
Author
There are multiple reasons why one would want to link CRT statically.
Having said this, I can also confirm that we using this patch internally for our app that links CRT statically and it works fine / robust :) |
Contributor
Author
|
@microsoft-github-policy-service agree company="Roblox" |
|
Hi, |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.