.NET: Fix AddWorkflow default lifetime to Transient for concurrent runs#4813
Open
Greal-dev wants to merge 5 commits intomicrosoft:mainfrom
Open
.NET: Fix AddWorkflow default lifetime to Transient for concurrent runs#4813Greal-dev wants to merge 5 commits intomicrosoft:mainfrom
Greal-dev wants to merge 5 commits intomicrosoft:mainfrom
Conversation
lokitoth
approved these changes
Mar 25, 2026
peibekwe
approved these changes
Mar 25, 2026
|
@Greal-dev please read the following Contributor License Agreement(CLA). If you agree with the CLA, please reply with the following information.
Contributor License AgreementContribution License AgreementThis Contribution License Agreement (“Agreement”) is agreed to by the party signing below (“You”),
|
Member
|
@Greal-dev Thank you for the contribution! If possible, please agree to the CLA, so we can expedite merging the change |
SergeyMenshykh
approved these changes
Mar 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes the default DI lifetime for
AddWorkflowfromServiceLifetime.SingletontoServiceLifetime.Transientto preventTakeOwnershipconflicts when running multiple concurrent workflow executions. SinceWorkflowis a stateful object with exclusive ownership semantics, registering it as a singleton makes it impossible to safely handle parallel requests targeting the same workflow key. The corresponding test is updated to reflect the new default behavior.Addresses #3620.