Fixed substition flow types of NoInfer types#59834
Closed
Andarist wants to merge 3 commits intomicrosoft:mainfrom
Closed
Fixed substition flow types of NoInfer types#59834Andarist wants to merge 3 commits intomicrosoft:mainfrom
NoInfer types#59834Andarist wants to merge 3 commits intomicrosoft:mainfrom
Conversation
typescript-bot
added
the
For Uncommitted Bug
Andarist
commented
Sep 3, 2024
Comment on lines
+16779
to
+16782
| if (isNoInferType(type)) { | ||
| constraints = append(constraints, (type as SubstitutionType).baseType); | ||
| return getNoInferType(getIntersectionType(constraints)); | ||
| } |
Contributor
Author
There was a problem hiding this comment.
Alternatively, I was thinking about handling the substitution types created here today (with NoInfer base types and non-unknown constraints) in isNoInferType (or at least handling such at the top of inferFromTypes). I concluded this is better and less error-prone though
typescript-bot
added
For Backlog Bug
Collaborator
|
With 6.0 out as the final release vehicle for this codebase, we're closing all PRs that don't fit the merge criteria for post-6.0 patches. If you think this was a mistake and this PR fits the post-6.0 patch criteria, please post to the 6.0 iteration issue with details (specifically, which PR and which patch criteria it satisfies). Next steps for PRs:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #59826