Skip to content

Conversation

@typescript-bot
Copy link
Contributor

Automated changes by create-pull-request GitHub action

@github-actions
Copy link
Contributor

Thanks for the PR!

This section of the codebase is owned by @saschanaz - if they write a comment saying "LGTM" then it will be merged.

* [MDN Reference](https://developer.mozilla.org/docs/WebAssembly/Reference/JavaScript_interface/Exception/getArg)
*/
getArg(index: number): any;
getArg(exceptionTag: Tag, index: number): any;
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Err... What? How is this web compatible?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

And this is not what the spec does. What happened 🤔

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Matches mdn, though?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

But if you follow the standard link it only has one index argument.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm, MDN's standard link is actually legacy now, and WebAssembly/spec#2052 says the base spec was wrong. Ok...

* [MDN Reference](https://developer.mozilla.org/docs/Web/API/ViewTransition/types)
*/
types: ViewTransitionTypeSet;
readonly types: ViewTransitionTypeSet;
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@saschanaz
Copy link
Collaborator

LGTM

@github-actions github-actions bot merged commit 05186dd into microsoft:main Feb 11, 2026
14 checks passed
@github-actions
Copy link
Contributor

Merging because @saschanaz is a code-owner of all the changes - thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants