-
Notifications
You must be signed in to change notification settings - Fork 464
Update core dependencies #2411
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update core dependencies #2411
Conversation
57f3467 to
77c106f
Compare
|
Thanks for the PR! This section of the codebase is owned by @saschanaz - if they write a comment saying "LGTM" then it will be merged. |
| * [MDN Reference](https://developer.mozilla.org/docs/WebAssembly/Reference/JavaScript_interface/Exception/getArg) | ||
| */ | ||
| getArg(index: number): any; | ||
| getArg(exceptionTag: Tag, index: number): any; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Err... What? How is this web compatible?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
And this is not what the spec does. What happened 🤔
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Matches mdn, though?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
But if you follow the standard link it only has one index argument.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hmm, MDN's standard link is actually legacy now, and WebAssembly/spec#2052 says the base spec was wrong. Ok...
| * [MDN Reference](https://developer.mozilla.org/docs/Web/API/ViewTransition/types) | ||
| */ | ||
| types: ViewTransitionTypeSet; | ||
| readonly types: ViewTransitionTypeSet; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
|
LGTM |
|
Merging because @saschanaz is a code-owner of all the changes - thanks! |
Automated changes by create-pull-request GitHub action