Open
Conversation
romanlutz
approved these changes
Apr 6, 2026
Contributor
|
It would be cool to have tests for these build scripts but that's a separate issue. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Currently, the
prepare_package.pyscript fails on Windows because it cannot findnpmeven though it is installed and accessible from the command line. This is apparently due to howsubprocesshandles aliases.To fix the issue, we look up the actual location of
npmand pass it to the subsequent script steps instead of passing directlynpm. This is confirmed to work on Windows and Copilot says this should be also compatible with Linux but a maintainer should confirm.