Implement reordering columns using the keyboard in <ColumnsButton>#10870
Closed
Implement reordering columns using the keyboard in <ColumnsButton>#10870
<ColumnsButton>#10870Conversation
Madeorsk
requested changes
Jul 31, 2025
Contributor
There was a problem hiding this comment.
UX feels a bit weird.
- We can now focus 2 different elements with tab: the list item, and the checkbox itself. I don't like that, it's way harder to reach the end of the list (twice as many keys to press), and it may cause confusions. What do you think about allowing to use the keys to move the columns while the checkbox is focused?
- If I start moving an item with space, then just cancel without moving (pressing space again), the item is moved up or down. It shouldn't.
- Why does the toggle and the drag indicator icon disappear when we enter "dragging mode"?
- If I leave the selector while still in move mode (by pressing escape or clicking away), it keeps its "dragging" state, maybe just cancel the move in this case. (I can get back to a state where I can move the previously selected column again by focusing something in MenuList, but it's not obvious).
Contributor
|
Also, I think you should remove e4989e0, we don't want to remove this as it's now merged in master. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Although it's possible to open the menu with space and to interact with its items using the keyboard, it’s impossible to drag and drop them with the keyboard.
Solution
Implement reordering columns using the keyboard.
How To Test
<ColumnsButton>is activeAdditional Checks
masterfor a bugfix or a documentation fix, ornextfor a feature