Skip to content

fix: global Buffer usage#962

Merged
boorad merged 2 commits intomargelo:mainfrom
chevsky:fix/global-buffer-usage
Mar 3, 2026
Merged

fix: global Buffer usage#962
boorad merged 2 commits intomargelo:mainfrom
chevsky:fix/global-buffer-usage

Conversation

@chevsky
Copy link
Contributor

@chevsky chevsky commented Mar 3, 2026

Fixes #961

Make RNQC work without calling install().

  • Use missing @craftzdog/react-native-buffer in the source code
  • Use Buffer from react-native-quick-crypto in tests

E2E tests and benchmarks still need install() as some parts require global.crypto.

@boorad boorad changed the title Fix global Buffer usage fix: global Buffer usage Mar 3, 2026
Copy link
Collaborator

@boorad boorad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

Thanks!

@boorad boorad merged commit e9ec818 into margelo:main Mar 3, 2026
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

🐛 Some modules use the global Buffer instance, causing crashes

2 participants