feat: Migrate Branch 5 kit#666
Merged
denischilik merged 6 commits intoworkstation/6.0-Releasefrom Mar 12, 2026
Merged
Conversation
thomson-t
reviewed
Mar 11, 2026
| if (value != null) parseValueGuarded(value) else null | ||
| } catch (e: Exception) { | ||
| Log.e(LogTag("pParticle"), "Unable to parse value: $value") | ||
| Log.e(LogTag("pParticle"), "Unable to parse custom data value") |
Author
There was a problem hiding this comment.
Yes, this is intentional. MobSF flagged this as android_kotlin_logging because $value can contain user-provided data
Comment on lines
30
to
+33
| - accept_self_signed_certificate | ||
| - android_manifest_well_known_assetlinks # Sample apps use third-party domains (e.g. Branch mp-fortune.app.link) | ||
| - android_task_hijacking1 # Sample apps; targetSdk in build.gradle | ||
| - android_task_hijacking2 # Sample apps; targetSdk in build.gradle |
Collaborator
There was a problem hiding this comment.
Can we add just that kit's test app path to the ignore list?
Author
There was a problem hiding this comment.
ignore-paths in mobsfscan doesn't exclude manifest files from scanning — they're checked separately. So we need to keep the ignore-rules for these three findings.
Made-with: Cursor
Made-with: Cursor
- Remove sensitive value from CustomDataParser log (android_kotlin_logging) - Add SampleApplication to ignore-paths and manifest rules to .mobsf (assetlinks, task hijacking for Branch sample app) Made-with: Cursor
denischilik
force-pushed
the
feat/SDKE-1019-Branch-5-Kit-Migrate
branch
from
51ef8c3 to
9e1fc8a
Compare
Made-with: Cursor
|
thomson-t
approved these changes
Mar 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Background
Migrates Branch 5 kit from git submodule to regular directory in the monorepo (
kits/branch/branch-5).What Has Changed
kits/branch/branch-5settings-kits.gradleupdated with new path (replaced:kits:branch-kit).gitmodulesScreenshots/Video
N/A
Checklist
Additional Notes